Stats: rename Total Likes and Total Comments Insights cards - #25891
Open
amitraj2203 wants to merge 1 commit into
Open
Stats: rename Total Likes and Total Comments Insights cards#25891amitraj2203 wants to merge 1 commit into
amitraj2203 wants to merge 1 commit into
Conversation
The two Insights cards show the last 7 days of data, but they were named "Total Likes" and "Total Comments", which made them look like all-time totals. Rename them to "Likes" and "Comments". Both strings move to new reverse-DNS keys, because localization keys are immutable. Rewording a key in place would keep the old, now stale, translations. The "This Year" labels in AnnualSiteStats keep their names, as those values really are totals. Fixes wordpress-mobile#23015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23015
The "Total Likes" and "Total Comments" cards on the Stats Insights tab show the last 7 days of data, but their names make them look like all-time totals. This renames them to "Likes" and "Comments".
Both strings now use new reverse-DNS keys instead of being reworded in place, because localization keys are immutable. Changing the text under the same key would keep the old translations, which no longer match the new English.
The "This Year" card is not changed. Its "Total Likes" and "Total Comments" labels live in
AnnualSiteStatsand those numbers really are totals.Testing instructions
Tested on an iPhone 17 simulator (iOS 26.5) with a WordPress.com site.