Add batch moderation to the rs comments list (Phase 2b) by nbradbury · Pull Request #23062 · wordpress-mobile/WordPress-Android

nbradbury · 2026-07-02T16:29:01Z

Description

Phase 2b, stacked on #23061: batch moderation for the rs comments list, matching the legacy list's action mode. Long-press a comment to enter selection mode and tap rows to build the selection; the top bar becomes a contextual action bar with the per-tab actions (approve/unapprove/spam/not-spam/trash/restore/delete), confirmation dialogs for trash and delete-permanently, and COMMENT_BATCH_* analytics.

Moderation runs the rs writes in parallel, aggregates failures into one snackbar ("n of m comments couldn't be updated"), then refreshes all initialized tabs since moderated comments move between them. Selection clears on tab change and after each action. Deliberate difference vs legacy: no undo snackbar — destructive actions confirm up front instead (same decision as the rs detail in #23051).

Testing instructions

On #23061's setup (flag on, WP.com or app-password site):

Long-press a comment in any tab

Selection mode: "N selected" top bar, checked avatar, per-tab actions (e.g. Approved tab → Unapprove/Spam/Trash; Trashed tab → Restore/Delete)

Select several comments and Approve/Unapprove/Spam

Applies immediately, selection clears, comments move to the right tabs

Trash and (from Trashed) Delete

Both ask for confirmation first; Delete permanently removes

Switch tabs with a selection active

Selection clears

Add a Compose comments list backed by wordpress-rs, following the postsrs/pagesrs pattern. There's no rs mobile-cache support for comments yet, so each tab pages directly against /wp/v2/comments using the response's nextPageParams as the cursor. - 5 filter tabs (All/Pending/Approved/Spam/Trashed). The All and Approved tabs use CommentStatus.Custom("all"/"approve") because WP_Comment_Query doesn't recognise the "approved" value the rs enum serialises to - Rows show avatar, bold "author on post" title (post titles resolved via a batched sparse-field request), snippet, date, pending indicator - Pull-to-refresh, load-more, retry snackbars, shimmer/empty/error states - Tapping a row opens the rs comment detail; the list refreshes on return - Gated in ActivityLauncher.viewUnifiedComments by RS_UNIFIED_COMMENTS + site capability (WP.com REST or application password), falling back to the legacy list; the now-dead per-tap rs gate inside the legacy list fragment is removed Batch moderation and search follow in stacked PRs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

dangermattic · 2026-07-02T16:29:29Z

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

	1 Message
📖	This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

wpmobilebot · 2026-07-02T16:43:06Z

📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

	App Name	WordPress Android
	Build Type	Debug
	Version	pr23062-a1fa82b
	Build Number	`1498`
	Application ID	`org.wordpress.android.prealpha`
	Commit	`a1fa82b`
	Installation URL	6sqtv3u3o1lpg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-07-02T16:43:16Z

📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Android
	Build Type	Debug
	Version	pr23062-a1fa82b
	Build Number	`1498`
	Application ID	`com.jetpack.android.prealpha`
	Commit	`a1fa82b`
	Installation URL	57j6o94241pho

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

codecov · 2026-07-02T16:47:02Z

Codecov Report

❌ Patch coverage is 0% with 203 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.39%. Comparing base (0217de3) to head (a1fa82b).

Files with missing lines	Patch %	Lines
...roid/ui/commentsrs/screens/CommentsRsListScreen.kt	0.00%	84 Missing ⚠️
...s/android/ui/commentsrs/CommentsRsListViewModel.kt	0.00%	58 Missing ⚠️
...ess/android/ui/commentsrs/CommentsRsListUiState.kt	0.00%	32 Missing ⚠️
...ndroid/ui/commentsrs/screens/CommentsRsListItem.kt	0.00%	25 Missing ⚠️
...d/ui/commentsrs/screens/CommentsRsTabListScreen.kt	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #23062      +/-   ##
==========================================
- Coverage   37.44%   37.39%   -0.06%     
==========================================
  Files        2337     2337              
  Lines      126454   126633     +179     
  Branches    17422    17446      +24     
==========================================
  Hits        47354    47354              
- Misses      75223    75402     +179     
  Partials     3877     3877

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…rience Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…g and SnackbarMessage Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Danger requires immutable string keys: changed copy gets a new key rather than editing the old one in place. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

- Key the post-title cache by (site, post id) so titles can't leak across sites, and negative-cache unresolvable ids so they aren't re-requested on every page load - Set perPage explicitly on title batches (server default of 10 silently truncated larger batches) and fall back to the pages endpoint for comments left unresolved by the posts endpoint - Discard load-more results whose fetch predates the latest applied first page, preventing stale pages/cursors after a silent refresh - Offer a retry action on load-more failures and auto-advance past pages that dedupe away entirely, so pagination can't stall at the list bottom Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

- Chunk post-title batches to the server's per_page maximum of 100; larger values are rejected outright with rest_invalid_param - Always attempt the pages endpoint for ids the posts endpoint didn't resolve, and only negative-cache when both endpoints succeeded - Clear negative-cached titles on user-initiated refresh so posts published after first sight can resolve - Cap unattended load-more auto-advance at 3 pages and let it handle empty pages, not just fully-deduplicated ones - Don't cancel/re-fire an identical in-flight title-resolve batch - Add CommentsRsDataSourceTest covering the cache, fallback, and chunking behavior, plus ViewModel tests for the new paging rules Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

- Cancel a tab's in-flight title-resolve job on user refresh so a job holding pre-clear 'not found' results can't re-apply them via the identical-ids guard - Generation-stamp the negative cache so a fetch already in flight when the user cleared can't re-poison entries with pre-clear results - Make the data source tests execute each request's builder lambda against a mocked uniffi client, asserting the endpoint, include count, and perPage actually sent — the chunking test now fails if chunking is reverted, and the posts-before-pages order is asserted, not assumed Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Resolves the Android Lint code-scanning alerts on CommentsRsDataSourceTest: SparseAnyPostWithViewContext and PostsRequestFilterListWithViewContextResponse are pure data classes, so the tests now build real instances. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

- Detail opened from the rs list backfills the FluxC cache (WP.com) and resolves the post title via rs, so title and like state are correct - Detail reports RESULT_OK only when the comment changed; the list only refreshes then, keeping paged lists and scroll position intact - Guard against duplicate first-page fetches; skip the retry snackbar when a silent refresh fails on a tab that already shows comments - Clear isLoadingMore when a refresh replaces the list so paging can't stall behind the busy guard - Stop the load-more trigger firing on the empty pre-layout list and re-arm it when the list size changes - Evict all cached post titles for the site on user refresh so renamed posts pick up their new title - Track COMMENT_FILTER_CHANGED on tab changes like the legacy list - Restore the singleTop launch mode the legacy comments activity has - Drop the dead initializingTabs bookkeeping - Merge RsCommentListItem into RsComment (one shared type and mapper) - Move the new unit tests to a follow-up PR to reduce this PR's size Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…list

- Delete the now-unused ActivityLauncher.viewUnifiedCommentsDetails - Track title-resolve jobs as a plain per-tab Job: cancel-and-relaunch is cheap because the data source caches resolved titles - Drop the dead tab parameter from onCommentClick and the unused snackbarMessages default argument Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…list

Long-press a comment to enter selection mode, then tap rows to build the selection. The top bar swaps to a contextual action bar offering the same per-tab actions as the legacy list's action mode (approve/unapprove/spam/ not-spam/trash/restore/delete), with confirmation dialogs for trash and delete-permanently and COMMENT_BATCH_* analytics. Moderation runs the rs writes in parallel, aggregates any failures into a single snackbar, then refreshes all initialized tabs, since moderated comments move between them. Selection clears on tab change and after each batch action. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…list-batch # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/commentsrs/CommentsRsListActivity.kt # WordPress/src/main/java/org/wordpress/android/ui/commentsrs/CommentsRsListUiState.kt # WordPress/src/main/java/org/wordpress/android/ui/commentsrs/CommentsRsListViewModel.kt # WordPress/src/main/java/org/wordpress/android/ui/commentsrs/screens/CommentsRsListItem.kt # WordPress/src/main/java/org/wordpress/android/ui/commentsrs/screens/CommentsRsListScreen.kt # WordPress/src/main/java/org/wordpress/android/ui/commentsrs/screens/CommentsRsTabListScreen.kt

The confirm button is wired directly to onConfirmPendingAction in the screen, so this field was never set or read. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

- Drop the single-use ConfirmationDialogState wrapper; pass pending confirmation and dismiss callback directly to the screen - Extract the confirmation dialogs into a private BatchConfirmationDialogs composable, removing the LongMethod suppression - Remove a redundant trailing semicolon in CommentsRsBatchAction Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

nbradbury added the Comments label Jul 2, 2026

nbradbury mentioned this pull request Jul 2, 2026

Add wordpress-rs comments list (Phase 2a: core browsing) #23061

Merged

5 tasks

nbradbury changed the base branch from feature/rs-comments-list to trunk July 2, 2026 16:33

nbradbury and others added 8 commits July 2, 2026 13:27

Rename RS comments experimental flag to cover the whole comments expe…

aad42b4

…rience Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Simplify rs comments list: drop dead/unused state, share page handlin…

a2cc6b3

…g and SnackbarMessage Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Use new string keys for the renamed experimental flag copy

3cd35f7

Danger requires immutable string keys: changed copy gets a new key rather than editing the old one in place. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

nbradbury force-pushed the feature/rs-comments-list-batch branch from 7ce128b to 26aaa08 Compare July 3, 2026 12:20

nbradbury added the unit-tests-exemption label Jul 3, 2026

nbradbury and others added 4 commits July 3, 2026 08:42

Merge remote-tracking branch 'origin/trunk' into feature/rs-comments-…

0c05ef5

…list

Merge remote-tracking branch 'origin/trunk' into feature/rs-comments-…

0f0c47d

…list

nbradbury force-pushed the feature/rs-comments-list-batch branch from 26aaa08 to 8a944bc Compare July 3, 2026 13:43

nbradbury and others added 3 commits July 3, 2026 15:01

Remove unused onConfirm field from ConfirmationDialogState

6351049

The confirm button is wired directly to onConfirmPendingAction in the screen, so this field was never set or read. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add batch moderation to the rs comments list (Phase 2b)#23062

Add batch moderation to the rs comments list (Phase 2b)#23062
nbradbury wants to merge 16 commits into
trunkfrom
feature/rs-comments-list-batch

nbradbury commented Jul 2, 2026

Uh oh!

dangermattic commented Jul 2, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 2, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 2, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nbradbury commented Jul 2, 2026

Description

Testing instructions

Uh oh!

dangermattic commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dangermattic commented Jul 2, 2026 •

edited

Loading

wpmobilebot commented Jul 2, 2026 •

edited

Loading

wpmobilebot commented Jul 2, 2026 •

edited

Loading

codecov Bot commented Jul 2, 2026 •

edited

Loading