build: fix make output formatting - #592
Merged
Merged
Conversation
The target printed 23 lines of usage text before checking VERSION_TYPE, so a valid invocation got the full help dump ahead of the release output. Move the text inside the error branch, leaving only the process header on the success path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The column width was hardcoded at 25 characters, so `build-resources-xcframework` (27) overflowed it and `test-android-library-e2e` (24) left a single space, breaking the alignment of both descriptions. Measure the longest name and pad to it, so adding a longer target keeps the column aligned rather than reintroducing this. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
[Type] Build Tooling
XCFramework BuildThis PR's XCFramework is available for testing. Add the following to your .package(url: "https://github.com/wordpress-mobile/GutenbergKit", branch: "pr-build/592")Built from 5bd8841 |
dcalhoun
marked this pull request as ready for review
August 20, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Two unrelated
makeoutput annoyances found while working on the release script.Why?
make release VERSION_TYPE=patchprinted 23 lines of usage text before doing anything, on every valid invocation.make helphardcoded its column width at 25 characters, sobuild-resources-xcframework(27) overflowed andtest-android-library-e2e(24) left a single space — both descriptions fell out of alignment.How?
Moved the usage text into the
VERSION_TYPE-is-empty branch. Invalid (non-empty) values still fall through tobin/release.sh, which validates them properly.make helpnow measures the longest target name and pads to it, so a future longer target won't reintroduce the misalignment.Testing Instructions
make release→ usage text, exit 1.make release VERSION_TYPE=patch DRY_RUN=true→ no usage dump.make help→ descriptions align in one column.