Skip to content

Check ctx extensions before rejecting a TLS1.3 certificate message extension #10936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aidangarske wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check ctx extensions before rejecting a TLS1.3 certificate message extension #10936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/tls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18044,10 +18044,14 @@ WOLFSSL_TEST_VIS int TLSX_Parse(WOLFSSL* ssl, const byte* input, word16 length,
#ifdef WOLFSSL_TLS13
/* RFC 8446 4.4.2: extensions in a Certificate message MUST
* correspond to ones offered in our prior ClientHello (client) or
* CertificateRequest (server). Reject anything we did not offer. */
* CertificateRequest (server). Reject anything we did not offer, but a
* CTX-level API leaves the extension on ctx->extensions, so look there
* too before concluding it was never offered. */
if (msgType == certificate &&
IsAtLeastTLSv1_3(ssl->version) &&
TLSX_Find(ssl->extensions, (TLSX_Type)type) == NULL) {
TLSX_Find(ssl->extensions, (TLSX_Type)type) == NULL &&
(ssl->ctx == NULL ||
TLSX_Find(ssl->ctx->extensions, (TLSX_Type)type) == NULL)) {
WOLFSSL_MSG("Cert-msg extension not offered in CH/CR");
SendAlert(ssl, alert_fatal, unsupported_extension);
WOLFSSL_ERROR_VERBOSE(UNSUPPORTED_EXTENSION);
Expand Down
Loading