DTLS bugfixes#10626
Open
mattia-moffa wants to merge 3 commits into
Open
Conversation
Follows RFC 9146 § 6. Fixes wolfSSL#10609
|
mattia-moffa
changed the title
Implements the receive-side of RFC 9147 § 9. On NewConnectionId, if usage is cid_immediate, switches our TX CID to the first usable CID; if usage is cid_spare, discards it. RequestConnectionId is parsed and ignored (responding is SHOULD in the RFC).
mattia-moffa
force-pushed
the
20260605-dtls-cid-check-newest
branch
from
d71c3b7 to
f495200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wolfSSL_dtls_set_pending_peer(),dtlsProcessPendingPeer()promoted the pending peer without checking that the record is newer than the newest already received. RFC 9146 § 6 requires to check this (second condition in the list). Without the check, a reordered or replayed CID record could cause an erroneous migration of the active peer. Fixes [Bug]: CID peer address update lacks a strict newer sequence-number gate #10609WOLFSSL_DTLS_CIDwithWOLFSSL_DTLS(not justWOLFSSL_DTLS13). Fixes [Bug]: CMake DTLS CID Option Incorrectly Requires DTLS 1.3 #10610Testing
Checklist