Fix UAF in callback wrapper and add input validation guards#10215
Draft
ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
Draft
Fix UAF in callback wrapper and add input validation guards#10215ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wolfSSL_ex_wrapper()whereHandShakeCallBackcould free the ssl session viainfo->ssl, then the wrapper would write to freed memory (ssl->hsInfoOn = 0)INVALID_DEVIDinwc_CryptoCb_RegisterDevice()— sentinel value should not consume a callback slotlistSz == 0inwolfSSL_SetStaticMemory()— zero buckets causes incorrect size calculations downstreamlen == 0INTEGER components (preventslen--underflow into massive memcpy) and validate ECC OID length (prevents overread on short/oversized token responses)Status
Early PR — fixes only, regression tests still need to be written. Each fix is traceable to a public-API PoC confirmed under ASan.
Test plan