Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents buffer overflow in SetSuitesHashSigAlgo() when parsing user-provided signature algorithm lists (notably RSA-PSS in TLS 1.3).
Changes:
- Add a preflight bounds check before calling
AddSuiteHashSigAlgo(). - Account for RSA-PSS + TLS 1.3 adding two entries (4 bytes) to the sigalg list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattia-moffa
force-pushed
the
20260413-fixes
branch
from
5d8c1cc to
99d1c80
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21599
Testing
./configure --enable-opensslextramake && make check