Skip to content

ci: rebuild mbedtls/nss in test job on cache miss#10202

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
LinuxJedi:fix-gha-cache
Apr 13, 2026
Merged

ci: rebuild mbedtls/nss in test job on cache miss#10202
dgarske merged 1 commit intowolfSSL:masterfrom
LinuxJedi:fix-gha-cache

Conversation

@LinuxJedi
Copy link
Copy Markdown
Member

The test jobs used actions/cache/restore with fail-on-cache-miss, which aborted when the cache key was scoped to another PR or had been evicted, even though the build job reported success.

Drop fail-on-cache-miss and add a fallback rebuild in the test job, gated on the cache-hit output. Fast path is unchanged; on miss the test job rebuilds locally and proceeds.

Fixes issue with PR #10189

Copilot AI review requested due to automatic review settings April 13, 2026 13:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the NSS and mbedTLS interop CI workflows so test jobs no longer hard-fail when the dependency cache is missing, by rebuilding the dependencies in the test job when actions/cache reports a miss.

Changes:

  • Remove fail-on-cache-miss from cache restore steps in test jobs.
  • Add cache-miss fallbacks that checkout and rebuild NSS/mbedTLS in the test jobs when needed.
  • Increase test job timeouts to accommodate the fallback rebuild path.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/nss.yml Removes cache-miss failure and adds a cache-miss rebuild path for NSS in the test job; increases timeout.
.github/workflows/mbedtls.yml Removes cache-miss failure and adds a cache-miss rebuild path for mbedTLS in the test job; slightly increases timeout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The test jobs used actions/cache/restore with fail-on-cache-miss,
which aborted when the cache key was scoped to another PR or had
been evicted, even though the build job reported success.

Drop fail-on-cache-miss and add a fallback rebuild in the test
job, gated on the cache-hit output. Fast path is unchanged; on
miss the test job rebuilds locally and proceeds.
@dgarske dgarske merged commit a67179e into wolfSSL:master Apr 13, 2026
400 of 402 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants