ci: rebuild mbedtls/nss in test job on cache miss#10202
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Apr 13, 2026
Merged
ci: rebuild mbedtls/nss in test job on cache miss#10202dgarske merged 1 commit intowolfSSL:masterfrom
dgarske merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the NSS and mbedTLS interop CI workflows so test jobs no longer hard-fail when the dependency cache is missing, by rebuilding the dependencies in the test job when actions/cache reports a miss.
Changes:
- Remove
fail-on-cache-missfrom cache restore steps in test jobs. - Add cache-miss fallbacks that checkout and rebuild NSS/mbedTLS in the test jobs when needed.
- Increase test job timeouts to accommodate the fallback rebuild path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/nss.yml | Removes cache-miss failure and adds a cache-miss rebuild path for NSS in the test job; increases timeout. |
| .github/workflows/mbedtls.yml | Removes cache-miss failure and adds a cache-miss rebuild path for mbedTLS in the test job; slightly increases timeout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The test jobs used actions/cache/restore with fail-on-cache-miss, which aborted when the cache key was scoped to another PR or had been evicted, even though the build job reported success. Drop fail-on-cache-miss and add a fallback rebuild in the test job, gated on the cache-hit output. Fast path is unchanged; on miss the test job rebuilds locally and proceeds.
bf30032 to
08aac33
Compare
dgarske
approved these changes
Apr 13, 2026
4 tasks
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test jobs used actions/cache/restore with fail-on-cache-miss, which aborted when the cache key was scoped to another PR or had been evicted, even though the build job reported success.
Drop fail-on-cache-miss and add a fallback rebuild in the test job, gated on the cache-hit output. Fast path is unchanged; on miss the test job rebuilds locally and proceeds.
Fixes issue with PR #10189