Various fixes

[mattia-moffa]

Description

Fixes ZD#21457 (27, 30, 31)

Testing

./configure --enable-pkcs12 && make && make check
./configure --host=aarch64-linux-gnu --enable-armasm --enable-mlkem && make && \
    qemu-aarch64 -L /usr/aarch64-linux-gnu/ -E LD_LIBRARY_PATH=./src/.libs ./tests/.libs/unit.test
./configure --enable-opensslextra && make && make check

[Copilot]

Pull request overview

Security and correctness fixes across PKCS#12 verification, OpenSSL-compat EVP HMAC verification, and ARMv8 ML-KEM NEON compare logic, with new regression tests to prevent bypasses.

Changes:

• Harden PKCS#12 MAC verification by rejecting MACs whose encoded digest length doesn’t match the algorithm’s digest size.
• Tighten EVP HMAC DigestVerifyFinal handling of signature lengths and add a regression test for the zero-length-tag forgery case.
• Fix ML-KEM NEON compare reduction logic on AArch64 and add a decapsulation tamper/FO-rejection test.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
wolfcrypt/src/port/arm/armv8-mlkem-asm.S	Adjusts NEON reduction step in mlkem_cmp_neon to fold upper 64-bits into lower before scalar check.
wolfcrypt/src/port/arm/armv8-mlkem-asm_c.c	Mirrors the NEON reduction fix in the inline-asm C implementation.
wolfcrypt/src/pkcs12.c	Rejects PKCS#12 MAC verification when the computed digest size doesn’t match the parsed digest length (prevents truncated-MAC bypass).
wolfcrypt/src/evp.c	Changes HMAC DigestVerifyFinal length validation and removes truncated-tag acceptance.
tests/api/test_pkcs12.h	Registers new PKCS#12 truncated-MAC bypass regression test.
tests/api/test_pkcs12.c	Adds crafted PKCS#12 fixture test ensuring truncated MAC digest is rejected.
tests/api/test_mlkem.h	Registers new ML-KEM FO rejection test.
tests/api/test_mlkem.c	Adds ciphertext-tamper test to ensure FO re-encryption check triggers implicit rejection.
tests/api/test_evp_pkey.h	Registers new EVP HMAC zero-length verification regression test.
tests/api/test_evp_pkey.c	Adds test ensuring EVP_DigestVerifyFinal rejects zero-length HMAC tags.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mattia-moffa]

Jenkins retest this please

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mattia-moffa]

Jenkins retest this please

[SparkiDev]

Please resolve conflicts.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #10192

Scan targets checked: wolfcrypt-api_misuse, wolfcrypt-bugs, wolfcrypt-compliance, wolfcrypt-concurrency, wolfcrypt-consttime, wolfcrypt-defaults, wolfcrypt-mutation, wolfcrypt-portability, wolfcrypt-proptest, wolfcrypt-src, wolfcrypt-zeroize

No new issues found in the changed files. ✅

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

MemBrowse Memory Report

No memory changes detected for:

• gcc-arm-cortex-m4- gcc-arm-cortex-m4-baremetal- gcc-arm-cortex-m4-min-ecc- gcc-arm-cortex-m4-tls12

[mattia-moffa]

Jenkins retest this please (failed because of flaky test which was fixed by e10ff38 but I rebased too soon)