Fix CHECKED_RETURN defects in test_configuration.c#1110
Open
ejohnstown wants to merge 1 commit into
Open
Conversation
Coverity flagged unchecked return values in the wolfsshd config tests: - Check the return code and the NULL check on the file handle returned by WFOPEN() in test_IncludeRecursionBound(). - Cast the return on WREMOVE() to void in test_IncludeRecursionBound() and CleanupWildcardTest(). Issues: CID-646430, CID-646431
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1110
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Coverity CHECKED_RETURN findings in the wolfsshd configuration unit tests by ensuring file-creation and cleanup calls are handled in a way that avoids “unchecked return” warnings and better reflects failure conditions.
Changes:
- Updated wildcard test setup to check
WFOPEN()’s return value before using the produced file handle. - Updated recursion-bound include test to treat
WFOPEN()failures as fatal and silenceWREMOVE()return values via(void)casts. - Added
(void)casts toWREMOVE()in cleanup paths to explicitly ignore return values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| WFOPEN(NULL, &f, filepath, "w"); | ||
| if (f) { | ||
| if (WFOPEN(NULL, &f, filepath, "w") == 0 && f != NULL) { |
|
|
||
| WFOPEN(NULL, &f, loopPath, "w"); | ||
| if (f == NULL) { | ||
| if (WFOPEN(NULL, &f, loopPath, "w") != 0 || f == NULL) { |
| WFOPEN(NULL, &f, normalPath, "w"); | ||
| if (f == NULL) { | ||
| WREMOVE(0, loopPath); | ||
| if (WFOPEN(NULL, &f, normalPath, "w") != 0 || f == NULL) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverity flagged unchecked return values in the wolfsshd config tests:
Issues: CID-646430, CID-646431