Fix loopback interface. Add new tests, remove deprecated tests.#102
Fix loopback interface. Add new tests, remove deprecated tests.#102gasbytes merged 8 commits intowolfSSL:masterfrom
Conversation
danielinux
commented
Apr 15, 2026
danielinux
commented
- minor fixes: exclude posix headers from non-posix builds, remove DEBUG defined by default in wolfip.h
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #102
Scan targets checked: wolfip-bugs, wolfip-compliance, wolfip-defaults, wolfip-mutation, wolfip-proptest, wolfip-src
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
There was a problem hiding this comment.
Pull request overview
Updates wolfIP’s loopback device behavior and related CI/tests, while also tightening platform-specific includes and debug defaults.
Changes:
- Reworked loopback to buffer outgoing IP payloads and deliver them via a new loopback
poll()path instead of immediate in-send receive. - Added/updated unit tests and regression tests around the new loopback behavior; removed reliance on a deprecated loopback test.
- Stopped defining
DEBUGby default and gated POSIX-only includes; added a CI smoke ping against127.0.0.1.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
wolfip.h |
Removes default DEBUG define to avoid debug-on-by-default builds. |
src/wolfip.c |
Adds loopback buffering + poll() implementation; adjusts debug include gating; wraps POSIX headers. |
src/test/unit/unit_tests_proto.c |
Adds loopback poll() tests and updates loopback regression expectations. |
src/test/unit/unit.c |
Registers new unit tests and replaces the deprecated regression test. |
config.h |
Enables loopback by default. |
.github/workflows/linux.yml |
Adds a loopback ICMP smoke test (no TUN/TAP). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #102
Scan targets checked: wolfip-bugs, wolfip-compliance, wolfip-defaults, wolfip-mutation, wolfip-proptest, wolfip-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #102
Scan targets checked: wolfip-bugs, wolfip-compliance, wolfip-defaults, wolfip-mutation, wolfip-proptest, wolfip-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
