Use enum size instead of MAX_BENCH_OPS#456
Open
padelsbach wants to merge 2 commits into
Open
Conversation
padelsbach
force-pushed
the
remove-fixed-benchmark-count
branch
2 times, most recently
from
July 16, 2026 22:48
48b7c7e to
4c636e5
Compare
padelsbach
force-pushed
the
remove-fixed-benchmark-count
branch
from
July 17, 2026 00:13
4c636e5 to
8818e8c
Compare
padelsbach
requested review from
Frauschi and
bigbrett
and removed request for
Frauschi
July 17, 2026 02:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this change switches wh_bench.c from CRLF to LF. Turn off the whitespace comparison when reviewing the diff for sanity.
This change removes
MAX_BENCH_OPSwhich needed to be adjusted whenever the test list was updated. Instead, just use the size of the enum.