Restore SHA3 client state when the server cannot offload#455
Merged
Frauschi merged 1 commit intoJul 20, 2026
Conversation
aidangarske
force-pushed
the
fix/sha3-cryptocb-fallback-state
branch
from
July 16, 2026 22:23
b74731e to
2d1f1c1
Compare
bigbrett
approved these changes
Jul 17, 2026
Frauschi
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two fixes that where causing the latent H5 failures
Restore SHA3 client state when the server cannot offload. The client mutated
shabefore the server answeredNOT_COMPILED_IN, so wolfCrypt's software fallback absorbed the tail twice and silently returned a wrong digest (SHA3-224 at len=145). Found on real H5 hardware.Secure server is built without SHA3 (wolfBoot, separate change). The NS client has
WOLFSSL_SHA3, the server does not, so SHA3 returnsrc=-174. NeededWOLFSSL_SHA3+sha3.oin the secure build.Fixes latent failures in #412 found when trying to reproduce I exposed this on real HW tests. failing the clinet Config test