Skip to content

NVM locking: improve locking across the crypto layer #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rizlik wants to merge 6 commits into
base: main
Choose a base branch
from
Open

NVM locking: improve locking across the crypto layer #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
caa44e9
mldsa: fix usage flags in ml-dsa DMA test
rizlik Jul 9, 2026
d96b6be
widetree: add and consolidate locking in crypto layer
rizlik Jun 30, 2026
b71dccb
test: add USAGE flag in DSA tests
rizlik Jul 9, 2026
2c584c4
formatting fixes
rizlik Jul 9, 2026
80909e6
address reviewer's comments
rizlik Jul 15, 2026
0df9151
server_crypto: remove DEBUG print
rizlik Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/wh_server_cert.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,8 @@ static int DerNextSequence(const uint8_t* input, uint32_t maxIdx,
}


/* Caller (the cert request dispatch) holds the non-recursive
* WH_SERVER_NVM_LOCK, so only unlocked keystore primitives may be used here. */
static int _verifyChainAgainstCmStore(
whServerContext* server, WOLFSSL_CERT_MANAGER* cm, const uint8_t* chain,
uint32_t chain_len, const whNvmId* trustedRootNvmIds, uint16_t numRoots,
Expand Down Expand Up @@ -486,6 +488,7 @@ static int _verifyChainAgainstCmStore(
if (WH_KEYID_ISERASED(*inout_keyId)) {
rc = wh_Server_KeystoreGetUniqueId(server, inout_keyId);
if (rc != WH_ERROR_OK) {
wc_FreeDecodedCert(&dc);
return rc;
}
}
Expand Down Expand Up @@ -1165,7 +1168,7 @@ int wh_Server_HandleCertRequest(whServerContext* server, uint16_t magic,
if (rc == WH_ERROR_OK) {
rc = wh_Server_CertVerifyCache_Clear(server);
(void)WH_SERVER_NVM_UNLOCK(server);
}
} /* WH_SERVER_NVM_LOCK() */
#else
rc = wh_Server_CertVerifyCache_Clear(server);
#endif
Expand Down Expand Up @@ -1193,7 +1196,7 @@ int wh_Server_HandleCertRequest(whServerContext* server, uint16_t magic,
rc = wh_Server_CertVerifyCache_SetEnabled(server,
req.enable);
(void)WH_SERVER_NVM_UNLOCK(server);
}
} /* WH_SERVER_NVM_LOCK() */
#else
rc = wh_Server_CertVerifyCache_SetEnabled(server, req.enable);
#endif
Expand Down
Loading
Loading