Skip to content

wolfCOSE test additions and hardening#40

Merged
dgarske merged 39 commits into
wolfSSL:mainfrom
aidangarske:cose-hardening
Jun 3, 2026
Merged

wolfCOSE test additions and hardening#40
dgarske merged 39 commits into
wolfSSL:mainfrom
aidangarske:cose-hardening

Conversation

@aidangarske
Copy link
Copy Markdown
Member

@aidangarske aidangarske commented Jun 2, 2026 •
edited
Loading 

F-5213, F-5214, F-5215, F-5216, F-5217, F-5218, F-5219, F-5220, F-5221, 
F-5228, F-5229, F-5230, F-5231, F-5232, F-5233, F-5234, F-5235, F-5236, 
F-5237, F-5238, F-5239, F-5240, F-5241, F-5242, F-5243, F-5244, F-5248, 
F-5249, F-5251, F-5282, F-5283, F-5284, F-5285, F-5286, F-5287, F-5288, 
F-5289, F-5290, F-5291, F-5292, F-5293, F-5294, F-5295, F-5296, F-5297, 
F-5299, F-5300, F-5301, F-5303, F-5304, F-5361, F-5365, F-5366, F-5367, 
F-5368, F-5369, F-5370, F-5371, F-5372, F-5373, F-5374, F-5375, F-5376, 
F-5377

aidangarske added 30 commits June 1, 2026 15:39
@aidangarske
F-5213/F-5251 - Reject trailing data after top-level COSE objects
b547096
@aidangarske
F-5214/F-5282 - Reject oversized header and key integers before int32…
6ca0a88 
… narrowing
@aidangarske
F-5216/F-5283 - Harden CBOR encoder bounds and reject oversized conta…
6c3245f 
…iner counts
@aidangarske
F-5304/F-5361 - Clear stale state and reject trailing data before COS…
a4f5376 
…E_Key import
@aidangarske
F-5215/F-5220/F-5366 - Require fixed-length EC2 coordinates per RFC 9053
b87d16e
@aidangarske
F-5218/F-5288/F-5365 - Validate recipient and signer unprotected headers
c76b5e0
@aidangarske
F-5221 - Reject multi-recipient ECDH-ES direct messages on decrypt
078bfb5
@aidangarske
F-5285 - Use zero-length protected header for direct COSE_Encrypt rec…
e643270 
…ipients
@aidangarske
F-5367/F-5377 - Classify recipient key-management alg and enforce alg…
66244ef 
…Id policy
@aidangarske
F-5284 - Decode kid in the protected header bucket
6a54815
@aidangarske
F-5301 - Require ML-DSA key level to match the algorithm level
a5247d2
@aidangarske
F-5289 - Enforce minimum HMAC key length for COSE MAC
2043c33
@aidangarske
F-5231/F-5303 - Validate MAC payload arguments for Mac0 and Mac
c36b58e
@aidangarske
F-5291 - Clear header outputs on verify and decrypt failure
a249269
@aidangarske
F-5295 - Give wolfCose_BuildEncStructure internal linkage
96a81a8
@aidangarske
F-5237/F-5368/F-5372/F-5244 - Fix trivial MISRA required-rule violations
874d688
@aidangarske
F-5235/F-5236/F-5239/F-5242/F-5243/F-5292/F-5293/F-5294/F-5370 - Docu…
582ba58 
…ment MISRA deviations
@aidangarske
F-5238/F-5240/F-5369 - Fix DEMO_ASSERT parens, const cast, shared tes…
a27d1eb 
…t header
@aidangarske
F-5299 - Document detached COSE_Encrypt unsupported and fix misleadin…
3126d0a 
…g test
@aidangarske
F-5228/F-5229/F-5230/F-5290 - Document AEAD nonce, short-tag, and alg…
bec1ad8 
…-pinning guidance
@aidangarske
F-5250/F-5302 - Reject lengths that would truncate to word32
a987a6b
@aidangarske
F-5217/F-5286/F-5287 - Document recipient encoding analysis (empty-bs…
be48cb2 
…tr correct; KW alg RFC-legal)
@aidangarske
F-5297 - Add CBOR INT64_MAX/INT64_MIN boundary decode tests
7fdfb3d
@aidangarske
F-5376 - Add empty inline-payload Mac0 roundtrip test
df40fd7
@aidangarske
F-5232/F-5233/F-5234 - Assert AEAD/MAC structure context bytes
f812f49
@aidangarske
F-5296 - Add ECDH-ES recipient-protected-to-CEK binding test
e99e715
@aidangarske
F-5248/F-5249 - Add per-recipient roundtrip tests for direct multi-re…
456589b 
…cipient Encrypt/MAC
@aidangarske
F-5300/F-5375 - Cover all eight AES-CCM parameter sets (Encrypt0 and …
f9760ee 
…multi)
@aidangarske
F-5373 - Assert RSA private-key encode scrubs scratch tail past outLen
9ada36d
@aidangarske
F-5374 - Reject non-preferred CBOR encodings per RFC 8949 determinist…
e9c47ee 
…ic rules
Copilot AI review requested due to automatic review settings June 2, 2026 19:51
@aidangarske aidangarske self-assigned this Jun 2, 2026

This comment was marked as resolved.

Sign in to view

@aidangarske aidangarske added enhancement New feature or request feature Feature addition hardening labels Jun 2, 2026
wolfSSL-Fenrir-bot

This comment was marked as resolved.

Sign in to view

@loganaden
Copy link
Copy Markdown

loganaden commented Jun 3, 2026

@aidangarske F-5213/F-5251 - Reject trailing data after top-level COSE objects looks good to me.

@aidangarske aidangarske marked this pull request as ready for review June 3, 2026 19:17
@aidangarske aidangarske requested a review from dgarske June 3, 2026 19:20
@dgarske dgarske merged commit db583d3 into wolfSSL:main Jun 3, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dgarske dgarske dgarske approved these changes

+1 more reviewer

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@aidangarske aidangarske

Labels

enhancement New feature or request feature Feature addition hardening

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aidangarske @loganaden @dgarske @wolfSSL-Fenrir-bot