[Incubator.Slider] Add useRelativeDrag prop for relative drag mode#3968
[Incubator.Slider] Add useRelativeDrag prop for relative drag mode#3968
Conversation
Added .hitSlop() to the RNGH Gesture.Pan() on the thumb so the gesture handler natively recognizes touches in the expanded hit area on Android. Also added hitSlop to the Pan gesture mock in jest setup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a container-level RNGH Gesture.Pan() that moves the thumb relative to its current position when useRelativeDrag is true. The thumb gets pointerEvents="none" so the container gesture takes over, and isActive is passed to keep the thumb's active styling in sync. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
How to reproduceDrop this into import React, {useState} from 'react';
import {Platform} from 'react-native';
import {View, Text, Switch, Incubator} from 'react-native-ui-lib';
const TAG = `[Slider-${Platform.OS}]`;
export default function PlaygroundScreen() {
const [disabled, setDisabled] = useState(false);
return (
<View flex padding-20>
<Text text60 marginB-20>
Slider Debug ({Platform.OS})
</Text>
<View row centerV marginB-20>
<Text text70 marginR-10>
Disabled
</Text>
<Switch value={disabled} onValueChange={setDisabled}/>
</View>
<Text text70 marginB-10>
Incubator.Slider (normal)
</Text>
<View
style={{width: '100%', height: 60, justifyContent: 'center'}}
onTouchStart={() => console.log(`${TAG} - PARENT onTouchStart`)}
onTouchEnd={() => console.log(`${TAG} - PARENT onTouchEnd`)}
>
<Incubator.Slider
value={30}
minimumValue={0}
maximumValue={100}
disabled={disabled}
onSeekStart={() => console.log(`${TAG} - Incubator.Slider - onSeekStart`)}
onSeekEnd={() => console.log(`${TAG} - Incubator.Slider - onSeekEnd`)}
onValueChange={(v: number) => console.log(`${TAG} - Incubator.Slider - onValueChange: ${v.toFixed(1)}`)}
/>
</View>
<Text text70 marginT-40 marginB-10>
Incubator.Slider (useRelativeDrag)
</Text>
<View
style={{width: '100%', height: 60, justifyContent: 'center'}}
onTouchStart={() => console.log(`${TAG} - PARENT onTouchStart (relative)`)}
onTouchEnd={() => console.log(`${TAG} - PARENT onTouchEnd (relative)`)}
>
<Incubator.Slider
value={30}
minimumValue={0}
maximumValue={100}
disabled={disabled}
useRelativeDrag
onSeekStart={() => console.log(`${TAG} - Incubator.Slider (relative) - onSeekStart`)}
onSeekEnd={() => console.log(`${TAG} - Incubator.Slider (relative) - onSeekEnd`)}
onValueChange={(v: number) => console.log(`${TAG} - Incubator.Slider (relative) - onValueChange: ${v.toFixed(1)}`)}
/>
</View>
</View>
);
}What to test
|
There was a problem hiding this comment.
Added a couple of comments but I did not go over everything, because:
The one downside to this version is not being able to click on the slider to move to the point automatically, if we can do that then why not make this the way it works? Is there any other downside I have missed?
Edit: you can re-add that functionality by reverting the change to onPress={useRelativeDrag ? undefined : onTrackPress}
|
Fixed, now pressing on the Thumb working also along side the new behavior |
M-i-k-e-l
left a comment
There was a problem hiding this comment.
Are you aware that useRange + useRelativeDrag is "silently broken"
In range mode it would only ever move the min thumb
| .onBegin(() => { | ||
| containerDragStartOffset.value = defaultThumbOffset.value; | ||
| isContainerDragging.value = true; | ||
| _onSeekStart(); |
There was a problem hiding this comment.
Double onSeekStart when starting on the thumb (only on thumb)
Move _onSeekStart to onStart, also move the one in thumb to onStart
| * If true, dragging anywhere on the slider moves the thumb relative to its current position | ||
| * instead of snapping to the touch point. Designed for single-thumb mode. | ||
| */ | ||
| useRelativeDrag?: boolean; |
There was a problem hiding this comment.
slider.api.json note updated
|
Unrelated to your changes, please remove (as it sometimes breaks the screen): |
Description
Adds
useRelativeDragsupport toIncubator.Slider.Uses a container-level RNGH
Gesture.Pan()withpointerEvents="none"on the thumb — dragging anywhere on the slider moves the thumb relative to its current position instead of snapping to the touch point. Designed for single-thumb mode.Changelog
Incubator.Slider - Added
useRelativeDragprop for relative drag mode.Additional info