Fix Major Crashes on Android#8284
Closed
OneAboveAll1964 wants to merge 8 commits intowix:masterfrom
Closed
Conversation
…n activity is destroyed Initialize layoutFactory early if activity is available on TurboModule init, and guard against null activity before creating the view tree. Adds null-safe access to activity, window, and decorView across Presenter, LayoutDirectionApplier, and RootPresenter.
…tart fix(android): prevent NullPointerException crashes during setRoot when activity is destroyed
1 task
Contributor
|
Included in internal PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of a patch i made before which got merged, it significantly reduced the crashes, this PR solves the below crashes completely (screenshot from before, now we have 0 events from those crashes)
the PR adds more safety checks and a suggestion made by @Belobopka
issues reference: issue