Skip to content

fix(resolveGgmlTypeOption): accept case-insensitive ggml type names #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreinknv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(resolveGgmlTypeOption): accept case-insensitive ggml type names #607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/gguf/types/GgufTensorInfoTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,16 @@ export function resolveGgmlTypeOption(option?: keyof typeof GgmlType | GgmlType)

if (typeof option === "number" && Object.hasOwn(GgmlType, option))
return option as GgmlType;
else if (typeof option === "string" && Object.hasOwn(GgmlType, option))
return GgmlType[option as keyof typeof GgmlType];
else if (typeof option === "string") {
// GgmlType enum keys are conventionally uppercase (e.g. "Q8_0",
// "F16", "BF16"). Accept lowercase / mixed-case inputs so config
// files and CLI flags don't silently fall through to the default.
// Prior behaviour treated e.g. "q8_0" as unrecognised and returned
// undefined — callers then fell back to F16 with no warning.
const upper = option.toUpperCase();
if (Object.hasOwn(GgmlType, upper))
return GgmlType[upper as keyof typeof GgmlType];
}

return undefined;
}