Disallow nested ternary expressions in ESLint [WPB-22420]#21733
Merged
Conversation
Add the no-nested-ternary rule and refactor existing violations to equivalent if/else logic without behavior changes. Also apply small prettier auto-fixes in webapp files that already failed lint on dev so affected lint passes when the webapp project is included.
thisisamir98
requested review from
arjita-mitra,
e-maad,
ikotarac,
otto-the-bot,
screendriver and
zskhan
as code owners
thisisamir98
changed the title
Restore nine webapp files to their dev formatting. The prior eslint --fix pass used local Prettier 3.8.4, which disagrees with CI's 3.9.4 on union-type layout and caused false prettier/prettier failures such as in MLSConversations.ts.
zskhan
previously approved these changes
Jul 3, 2026
|
screendriver
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the no-nested-ternary rule and refactor existing violations to equivalent if/else logic without behavior changes. Also apply small prettier auto-fixes in webapp files that already failed lint on dev so affected lint passes when the webapp project is included.