Skip to content

chore: remove unused log file writer v1 [WPB-26807]#5024

Open
MohamadJaara wants to merge 2 commits into
developfrom
mo/remove-unused-log-writer-v1
Open

chore: remove unused log file writer v1 [WPB-26807]#5024
MohamadJaara wants to merge 2 commits into
developfrom
mo/remove-unused-log-writer-v1

Conversation

@MohamadJaara

@MohamadJaara MohamadJaara commented Jul 3, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-26807

Summary

  • Remove the unused LogFileWriterV1Impl implementation.
  • Make LogWriterModule always provide LogFileWriterV2Impl.
  • Remove the obsolete use_async_flush_logging BuildConfig flag from configuration generation.

Why

LogFileWriterV2Impl is the active log file writer path, so the V1 fallback and its selector flag are no longer needed. Keeping both paths adds maintenance overhead without any current runtime use.

Validation

  • ./gradlew :app:testDevDebugUnitTest

@MohamadJaara MohamadJaara marked this pull request as ready for review July 3, 2026 10:09
@MohamadJaara MohamadJaara changed the title Remove unused log file writer v1 chore: remove unused log file writer v1 Jul 3, 2026
@pull-request-size pull-request-size Bot added size/L and removed size/S labels Jul 3, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@MohamadJaara MohamadJaara changed the title chore: remove unused log file writer v1 chore: remove unused log file writer v1 [WPB-26807] Jul 3, 2026
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.43%. Comparing base (5487909) to head (19d667a).

Files with missing lines Patch % Lines
...m/wire/android/util/logging/LogFileWriterConfig.kt 0.00% 1 Missing ⚠️
...com/wire/android/util/logging/LogFileWriterImpl.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5024      +/-   ##
===========================================
+ Coverage    49.27%   49.43%   +0.16%     
===========================================
  Files          653      652       -1     
  Lines        23553    23475      -78     
  Branches      3615     3600      -15     
===========================================
  Hits         11606    11606              
+ Misses       10873    10795      -78     
  Partials      1074     1074              
Files with missing lines Coverage Δ
...m/wire/android/util/logging/LogFileWriterConfig.kt 0.00% <0.00%> (ø)
...com/wire/android/util/logging/LogFileWriterImpl.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5487909...19d667a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant