You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove the unused LogFileWriterV1Impl implementation.
Make LogWriterModule always provide LogFileWriterV2Impl.
Remove the obsolete use_async_flush_logging BuildConfig flag from configuration generation.
Why
LogFileWriterV2Impl is the active log file writer path, so the V1 fallback and its selector flag are no longer needed. Keeping both paths adds maintenance overhead without any current runtime use.
❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.43%. Comparing base (5487909) to head (19d667a).
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-26807
Summary
LogFileWriterV1Implimplementation.LogWriterModulealways provideLogFileWriterV2Impl.use_async_flush_loggingBuildConfig flag from configuration generation.Why
LogFileWriterV2Implis the active log file writer path, so the V1 fallback and its selector flag are no longer needed. Keeping both paths adds maintenance overhead without any current runtime use.Validation
./gradlew :app:testDevDebugUnitTest