test: group video call critical flow test (WPB-22855)#4629
Open
test: group video call critical flow test (WPB-22855)#4629
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
emmaoke-w
changed the title
CinnamonNinja
approved these changes
Mar 9, 2026
...src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/PersonalAccountLifeCycle.kt
Show resolved
Hide resolved
|
yamilmedina
reviewed
Apr 8, 2026
Contributor
yamilmedina
left a comment
yamilmedina
left a comment
There was a problem hiding this comment.
So far so good, 🚀 I would like to see this split into smaller PRs at least logically, so this can be tracked better and we can look backwards to know what/when we added tests for group calls
- Group video call test
- QR tests
- fixes and improvements
...src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/PersonalAccountLifeCycle.kt
Show resolved
Hide resolved
...testsCore/src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/GroupVideoCall.kt
Show resolved
Hide resolved
...testsCore/src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/GroupVideoCall.kt
Show resolved
Hide resolved
Comment on lines
+69
to
+87
| val deadline = SystemClock.uptimeMillis() + timeoutMs | ||
| var lastMenuClickAt = 0L | ||
|
|
||
| while (SystemClock.uptimeMillis() < deadline) { | ||
| if (tryClickIfVisible(settingsButton)) { | ||
| return this | ||
| } | ||
|
|
||
| val now = SystemClock.uptimeMillis() | ||
| if (now - lastMenuClickAt >= 600 && tryClickIfVisible(mainMenuButton)) { | ||
| lastMenuClickAt = now | ||
| device.waitForIdle(300) | ||
| } | ||
|
|
||
| SystemClock.sleep(120) | ||
| } | ||
|
|
||
| throw AssertionError("Settings menu entry was not found within ${timeoutMs}ms.") | ||
| } |
Contributor
There was a problem hiding this comment.
This is doing too much, can we split? or rename to make it clear about the delays/wait? or as a last resort to add a kdoc in the function so explains a bit the needed for this wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-22855
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
userSendMessageToPersonalMlsConversation), improved conversation timer lookup (personal/group fallback), and clearer failure reporting on send.FileUtilsto useMediaStoreon Android Q+ (scoped storage safe write to Downloads), with legacy path handling kept for older Android versions.SystemClock-based polling/retry across key flows (notification/consent dialogs, menu/settings click path, modal visibility/disappearance checks, download modal Save click).UiWaitUtils(waitUntilVisible,waitUntilToastIsDisplayed,iSeeSystemMessage,assertToastDisplayed) and strengthened element stabilization timing.Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.