Skip to content

use realistic coturn memory limits#50

Open
mastaab wants to merge 1 commit into
wireapp/4.6.2-federationfrom
coturn-memory-limits
Open

use realistic coturn memory limits#50
mastaab wants to merge 1 commit into
wireapp/4.6.2-federationfrom
coturn-memory-limits

Conversation

@mastaab

@mastaab mastaab commented Apr 1, 2026

Copy link
Copy Markdown

previous memory limits where necessary because of memory leaks.
coturns should never use this amount of memory, setting saner limits now

@mastaab mastaab force-pushed the coturn-memory-limits branch from b399248 to 849b993 Compare April 1, 2026 14:49
@sonarqubecloud

sonarqubecloud Bot commented Apr 1, 2026

Copy link
Copy Markdown

@mastaab mastaab requested review from lwille and smatting April 1, 2026 14:51
@mastaab mastaab requested review from siberijah and z-dule April 25, 2026 11:07
Comment thread charts/coturn/values.yaml
memory: 256Mi
limits:
memory: 6.5Gi
memory: 512Mi

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should be as agressive. A single coturn pod usually owns its node anyway and we should leave it up to the operator to set mem limits to whatever the node can tolerate.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason for this change is, that this limit is setting false expectations and lead to false sizing assumptions.
In prod, there is no coturn pod that is using more than 150mb. If a customer is sizing their coturn nodes, and they are driven by the limits here, the will be way too big and are just inflating the compute requirements (which especially on-prem need to be really tailored to what we need)
One can always overwrite the limits of course, but from my perspective the standard should reflect the reality.
Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants