Skip to content

WPB-15070 - Make calls to ur_addr_map_get thread safe by introducing locks #29

Open
e-lisa wants to merge 2 commits into
wireapp:wireapp/4.6.2-federationfrom
e-lisa:WPB-15070
Open

WPB-15070 - Make calls to ur_addr_map_get thread safe by introducing locks #29
e-lisa wants to merge 2 commits into
wireapp:wireapp/4.6.2-federationfrom
e-lisa:WPB-15070

Conversation

@e-lisa

@e-lisa e-lisa commented Dec 16, 2024

Copy link
Copy Markdown

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Calls to ur_addr_map_get are not thread-safe.

Solutions

Add global locks around calls to ur_addr_map_get

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant