WPB-14931 change coturn defaults, bump charts version#28
Conversation
|
it is required for a on-prem HA deployment, current defaults do not work, we should arrange a test on one of the cailleach envs or find a better solution, ill discuss with Julia today |
There was a problem hiding this comment.
From what I could find in cailleach, we always seem to override these with e.g. __COTURN_HOST_IP__ or __COTURN_EXT_IP__ - which speaks for the default values being dysfunctional
There's another default on the template level:
listening-ip={{ default "__COTURN_EXT_IP__" .Values.coturnTurnListenIP }}
If we change the default in the Values to be anything but null, we need to remove the defaults in the template to avoid confusion.
To support having different sets of defaults for different environments, we could introduce a second file, e.g. values-local-testing.yaml, and update the docs to reference both files, e.g. helm ... -f values.yaml -f values-local-testing.yaml.
|



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.