removed asserts#43
Conversation
There was a problem hiding this comment.
💡 Codex Review
Lines 175 to 176 in 3e31a33
Calling undoMove() when no prior move was pushed (for example immediately after setFEN() or after one extra undo) now reaches history.back()/pop_back() on an empty vector, which is undefined behavior and can crash in debug/test runs. The removed assert(!history.empty()) was the only local guard here, so this commit regresses fail-fast behavior into memory-unsafe behavior for a publicly callable method.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Fixes #42