Add Linux/macOS CLI readiness gates#14
Merged
Merged
Conversation
DeepSeekCode review of PR #14 (Add Linux/macOS CLI readiness gates)Let me examine the PR diff and repository structure to understand the changes. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71d7c0ab1a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
willamhou
force-pushed
the
linux-macos-cli-readiness-20260523
branch
from
71d7c0a to
d8fdc8b
Compare
DeepSeekCode review of PR #14 (Add Linux/macOS CLI readiness gates)Let me examine the PR diff and repository structure to understand the changes. |
willamhou
force-pushed
the
linux-macos-cli-readiness-20260523
branch
from
d8fdc8b to
36aa928
Compare
DeepSeekCode review of PR #14 (Add Linux/macOS CLI readiness gates)Let me examine the PR diff and repository structure more thoroughly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/create-multifile-external-fixture.shfor a disposable Python invoice multi-file dogfood repo and document the dry-run/evidence flow.Validation
scripts/create-multifile-external-fixture.sh /tmp/deepseek-external-fixture-smoke-20260523-btarget/debug/deepseek dogfood external-fixture --workdir /tmp/deepseek-external-fixture-smoke-20260523-b --dry-run 'replace \return amount - discount` with `return max(amount - discount, 0.0)` in src/invoice_math/pricing.py and replace `Invoice total` with `Final total` in src/invoice_math/summary.py, validate with python -m unittest discover -s tests'`timeout 10s target/debug/deepseek agents shell-fixture-smoke --jsontimeout 15s target/debug/deepseek agents service-smoke --workdir /tmp/dsc-smk --bin target/debug/deepseek --jsontarget/debug/deepseek tui --entrypoint-smoke --smoke-bin target/debug/deepseektarget/debug/deepseek task fixture-smoke --jsontarget/debug/deepseek github fixture-smoke --jsongit diff --checkcargo fmt --checknode scripts/check-secrets.jspython3 -c "import yaml; yaml.safe_load(open('.github/workflows/ci.yml')); yaml.safe_load(open('.github/workflows/release.yml'))"cargo test --lib -- --test-threads=1(1632 passed)