1095: Fix NPS survey close button alignment after submission - #353
Open
tomjn wants to merge 1 commit into
Open
Conversation
The confirmation-state rule centred the button horizontally, putting the glyph on top of the message text. The original report was about vertical alignment, so size the button box to its own font size instead, which lines it up with the first line of text in both states.
svandragt
removed their request for review
September 4, 2026 07:47
svandragt
approved these changes
Sep 4, 2026
Collaborator
|
Task is blocked see ticket. Don't merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The confirmation-state rule from #351 centred the close button horizontally, which puts the glyph on top of the confirmation message text. On mobile it lands between the two wrapped lines.
The original report was about vertical alignment, not horizontal, so this sizes the button box to its own font size instead. A 1.5rem square with centred content aligns to the first line of whatever sits next to it, so the form state and the confirmation state agree without a state-specific rule. It also takes the hit area from 15x29 to 24x24, which meets WCAG 2.2 SC 2.5.8.