Add support for sd-sind language code#504
Conversation
jdforrester
changed the title
T428848 is about Tsishingini (tsw), not Sindhi in Khudawadi script. Is there a different task for this? |
|
@Ami765 Thank you adding this pull request! @jdforrester It is related to https://phabricator.wikimedia.org/T428126. I've updated the ticket link in the task description. @Ami765 I am clarifying one thing on the support channel about the autonym: https://translatewiki.net/wiki/Support#Request_to_add_Sindhi_(Khudabadi)_on_translatewiki. Once I learn more, I can review the pull request. Hopefully soon. |
| sd: [sd-arab] | ||
| sd-arab: [Arab, [AS], سنڌي] | ||
| sd-deva: [Deva, [AS], सिंधी] | ||
| sd-sind: [Sind, [AS], "𑊧𑊩𑊡𑊻"] |
There was a problem hiding this comment.
Based on the description in the task, the autonym should be 𑋝𑋡𑋟𑋐𑋢.
| ], | ||
| "سنڌي" | ||
| ], | ||
| "sd-sind": [ |
There was a problem hiding this comment.
It looks like this file was hand-edited, not regenerated. data/language-data.json is generated from data/langdb.yaml by src/util/ulsdata2json.php. It must not be edited directly. Two symptoms confirm it was hand edited:
- Wrong ordering:
sd-sindis placed betweensd-arabandsd-deva - Invalid "ltr" field
Suggested recommendation here would be to regenerate the JSON via php src/util/ulsdata2json.php command.
There was a problem hiding this comment.
It looks like the script was not run to add these changes. Read steps 1-8 listed here https://www.mediawiki.org/wiki/Manual:Adding_and_removing_languages#language-data. They explain more about running the php src/util/ulsdata2json.php script. As I mentioned earlier, changes to data/language-data.json file should not be added manually. They need to be generated by running the php script.
There was a problem hiding this comment.
Also, Sind would need to be added here in the SouthAsian list.
Ami765
force-pushed
the
add-language-code
branch
2 times, most recently
from
94ef248 to
5688b04
Compare
| # Unicode, because linguistically and geographically it's closely related to | ||
| # the Brahmic family. | ||
| SouthAsian: [Beng, Cakm, Deva, Gujr, Guru, Knda, Mlym, Mtei, Olck, Orya, Rohg, Saur, Sinh, Sylo, Taml, Telu, Tibt, Thaa, Wara] | ||
| SouthAsian: [Beng, Cakm, Deva, Gujr, Guru, Knda, Mlym, Mtei, Olck, Orya, Rohg, Saur, Sinh, Sylo, Taml, Telu, Tibt, Thaa, Wara, Sind] |
There was a problem hiding this comment.
Sind should follow the alphabetical order and placed after Saur.
| ], | ||
| "سنڌي" | ||
| ], | ||
| "sd-sind": [ |
There was a problem hiding this comment.
It looks like the script was not run to add these changes. Read steps 1-8 listed here https://www.mediawiki.org/wiki/Manual:Adding_and_removing_languages#language-data. They explain more about running the php src/util/ulsdata2json.php script. As I mentioned earlier, changes to data/language-data.json file should not be added manually. They need to be generated by running the php script.
Ami765
force-pushed
the
add-language-code
branch
2 times, most recently
from
95be81e to
03a6eec
Compare
Bug: T428126
Ami765
force-pushed
the
add-language-code
branch
from
03a6eec to
0fc9704
Compare
3 participants
Bug: T428126