Add Tsishingini (tsw) language metadata

[gkm563]

Summary

This patch adds Tsishingini (tsw) to the language-data repository.

Changes:

• Add tsw to data/langdb.yaml
• Regenerate data/language-data.json using src/util/ulsdata2json.php

Validation

• Ran php src/util/ulsdata2json.php
• Ran YAML sort validation successfully
• Ran test suite successfully (npm test)

References

• Phabricator: T428848
• ISO 639-3 code: tsw
• Autonym: Tsishingini
• Script: Latn

Change-Id: I08e20d6d589dbeded2936ccf082ae9f439a6e89d

Feedback provided

[ToluAyodele]

Also, i'd recommend including a link Phabricator task in the commit, that way the task being worked on can be referenced directly. Similar to how it was done in this Merge Request for example: #476

[ToluAyodele]

Everything else looks good. However this change looks like it could have been caused by running the command php src/util/ulsdata2json.php and changes from CLDR were fetched.

When you initially ran php src/util/ulsdata2json.php, did you git diff to see if there was any changes made before running data/langdb.yaml following the docs here?

[gkm563]

Thank you for the review.

I checked the diff against the current upstream master branch. The intended changes are limited to:

• Adding tsw to data/langdb.yaml
• Regenerating data/language-data.json to include the corresponding tsw entry

I do not see any additional CLDR-related changes in the current diff against upstream. The generated JSON changes appear to be limited to the new language entry.

Thank you also for the suggestion regarding referencing the Phabricator task directly in the commit message. I'll follow that convention in future contributions.

[ToluAyodele]

Thanks for the response.

I tried replicating the steps from the language-data section of the documentation(here) and it seems that there's a patch that should have been created first before adding the language to Language data, which would be the patch that included the last line that was changed in the language-data.json file which updates the current version.

• You'd have to go ahead and update your local language-data master branch

• Create a new branch locally and run php src/util/ulsdata2json.php

• Then run git diff and if you see that there are changes made to any file within the repository as a result of the script being run, create a patch with the commit message "Updating territory-language information from upstream automatically"

After that's submitted, reviewed and merged, we can go ahead and rebase it on top of this commit then finalize this patch. And the steps I listed above are fully detailed in the language-data section of the documentation I linked in the beginning

[gkm563]

Thanks for the guidance.

I updated my local branch from upstream/master, ran php src/util/ulsdata2json.php, and created a separate patch for the generated update as suggested:

#505
Once that patch is reviewed/merged, I'll rebase the Tsishingini patch on top of it.