feat: add authorize hook and tempo subscriptions#331
Draft
brendanjryan wants to merge 2 commits intomainfrom
Draft
feat: add authorize hook and tempo subscriptions#331brendanjryan wants to merge 2 commits intomainfrom
brendanjryan wants to merge 2 commits intomainfrom
Conversation
brendanjryan
force-pushed
the
brendanryan/authorize-hook-subscriptions
branch
from
992c30a to
313f314
Compare
commit: |
Replace implicit state logic (isActive + getPeriodIndex checks) in the authorize hook with an explicit SubscriptionState discriminated union and pure transition(state, event) → state function. States: none | active | needsRenewal | expired | ambiguous Events: RESOLVE (find matching subscription) | CHECK_PERIOD (check renewal) - Add src/tempo/subscription/State.ts with types, transition, resolveState, getPeriodIndex - Refactor authorize hook to: resolveState → switch on status - Remove duplicated helpers from server/Subscription.ts - Add 31 unit tests covering all transition paths and edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.