fix: add missing DB pool settings to Settings — CRITICAL deploy blocker (#197)#197
fix: add missing DB pool settings to Settings — CRITICAL deploy blocker (#197)#197
Conversation
session.py references DB_POOL_SIZE, DB_POOL_MAX_OVERFLOW, DB_POOL_TIMEOUT and DB_POOL_RECYCLE_TIMEOUT but none of these existed in the Settings class, causing AttributeError on startup and 18+ consecutive Railway deploy failures. Adds sensible Railway-safe defaults (pool_size=5, max_overflow=10).
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 52 minutes and 16 seconds.Comment |
🚨 THIS WAS THE REAL DEPLOY BLOCKER
The Error
The app was crashing before Uvicorn even started — which explains why Railway's healthcheck saw zero HTTP requests reaching the container. Not a routing issue. Not a port issue. A hard Python crash at import time.
Root Cause
session.pyreferences 4 Settings attributes that didn't exist:settings.DB_POOL_SIZEsettings.DB_POOL_MAX_OVERFLOWsettings.DB_POOL_TIMEOUTsettings.DB_POOL_RECYCLE_TIMEOUTFix
Added all 4 to
Settingsclass inconfig.pywith Railway-safe defaults:Expected result after merge