fix(processor): preserve existing comment as fallback for accessor signatures#87
Closed
udayreddy-s wants to merge 2 commits into
Closed
fix(processor): preserve existing comment as fallback for accessor signatures#87udayreddy-s wants to merge 2 commits into
udayreddy-s wants to merge 2 commits into
Conversation
fix(processor): preserve existing comment as fallback for accessor signatures
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Closing this — after reviewing PR #71 more carefully, I realized this overlaps with the nullish coalescing improvement already proposed there. Apologies for the duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When resolving accessor types in processor.mjs, the existing
comment on the accessor was being unconditionally overwritten
by the signature comment — even when the signature comment
was undefined or empty.
This PR uses nullish coalescing (
??) to fall back to theexisting
accessor.commentwhen the signature comment ismissing, preserving any previously set comment.
This is a minimal, targeted improvement that avoids adding
unnecessary optional chaining on
getSignatureorsetSignaturethemselves — since as noted in #71, thesewill always be defined when the reflection kind is Accessor.
Relates to: #71
What kind of change does this PR introduce?
Bug fix — prevents accidental comment loss during
accessor type resolution
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
Use of AI
No AI was used for this change