Skip to content

feat: add 404 page#172

Merged
bjohansebas merged 3 commits into
webpack:mainfrom
TusharThakur04:feat/404-page
Jul 7, 2026
Merged

feat: add 404 page#172
bjohansebas merged 3 commits into
webpack:mainfrom
TusharThakur04:feat/404-page

Conversation

@TusharThakur04

Copy link
Copy Markdown
Member

Summary
This PR adds 404 page

What kind of change does this PR introduce?
feat

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI

@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jul 7, 2026 5:06pm

Request Review

Comment thread components/Layout.jsx Outdated
sponsors: SponsorsLayout,
blog: BlogLayout,
post: PostLayout,
PageNotFound: PageNotFoundLayout,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PageNotFound: PageNotFoundLayout,
404: PageNotFoundLayout,

nit

Comment on lines +20 to +22
<BaseButton href="/" kind="primary">
Go to Home
</BaseButton>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add another "Report an Issue" button that links to this repository

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to the root repository or issues section ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjohansebas bjohansebas merged commit ff5eca1 into webpack:main Jul 7, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants