Skip to content

fix(theme): pass pathname to NavBar for active link highlighting#171

Merged
ovflowd merged 3 commits into
mainfrom
fix/navbar-active-pathname
Jul 7, 2026
Merged

fix(theme): pass pathname to NavBar for active link highlighting#171
ovflowd merged 3 commits into
mainfrom
fix/navbar-active-pathname

Conversation

@ryzrr

@ryzrr ryzrr commented Jul 5, 2026

Copy link
Copy Markdown
Member

Summary
Passed pathname to NavBar for active link highlighting

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
No

Does this PR introduce a breaking change?
No

If relevant, what needs to be documented once your changes are merged or what have you already documented?
NA

Use of AI
No

Copilot AI review requested due to automatic review settings July 5, 2026 19:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jul 6, 2026 2:45pm

Request Review

Comment thread components/NavBar.jsx Outdated
@ryzrr

ryzrr commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@avivkeller @moshams272 PTAL! i have applied a fix and it is now highlighting on the api docs as well
image

Copilot AI review requested due to automatic review settings July 6, 2026 14:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@moshams272

Copy link
Copy Markdown
Contributor

I tried to use our functions to normalizing the links 👀

@ovflowd ovflowd merged commit da2df49 into main Jul 7, 2026
9 checks passed
@ovflowd ovflowd deleted the fix/navbar-active-pathname branch July 7, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants