ci: skip lifecycle scripts when installing on legacy Node.js versions - #213
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 9 9
Lines 848 848
Branches 360 361 +1
=======================================
Hits 809 809
Misses 35 35
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
evenstensberg
requested review from
alexander-akait
and
a lite review from Copilot
August 26, 2026 19:03
The legacy test lanes pin `typescript@4`, and `npm i` runs `prepare` -> `build` -> `build:types`. Recent `@types/node` releases ship `web-globals/streams.d.ts`, which only type-checks under TypeScript 5, so the install failed with TS2502 before any test could run. Those lanes only run Jest against `src`, so the build is not needed there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
evenstensberg
force-pushed
the
fix/legacy-node-install
branch
from
August 26, 2026 20:04
94d2f63 to
33269ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignores postinstall scripts that invokes
npm run prepareand explicitly runnpm run build:codefor legacy nodejs versions that doesnt have types.