Skip to content

Move the modelContext getter to Document#184

Merged
domfarolino merged 2 commits into
mainfrom
move-modelContext-document
May 27, 2026
Merged

Move the modelContext getter to Document#184
domfarolino merged 2 commits into
mainfrom
move-modelContext-document

Conversation

@domfarolino
Copy link
Copy Markdown
Collaborator

@domfarolino domfarolino commented May 26, 2026

Closes #173.

This PR does not update the explainer or associated examples. I'll make sure #183 does this, since it handles the explainer overhaul.

/cc @beaufortfrancois


Preview | Diff

Copy link
Copy Markdown
Contributor

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

Comment thread index.bs Outdated
@domfarolino domfarolino merged commit c7b5c70 into main May 27, 2026
2 checks passed
@domfarolino domfarolino deleted the move-modelContext-document branch May 27, 2026 15:04
github-actions Bot added a commit that referenced this pull request May 27, 2026
SHA: c7b5c70
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JeanMeche added a commit to JeanMeche/angular that referenced this pull request May 27, 2026
The implementation in Chrome 150 moved `modelContext` from the navigator to the document (see webmachinelearning/webmcp/pull/184)

We're also removing the calls to the deprecated `unregisterTool` method.

fixes angular#68947
JeanMeche added a commit to JeanMeche/angular that referenced this pull request May 27, 2026
The implementation in Chrome 150 moved `modelContext` from the navigator to the document (see webmachinelearning/webmcp/pull/184)

We're also removing the calls to the deprecated `unregisterTool` method.

fixes angular#68947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make tools Document-scoped instead of Window-scoped

4 participants