Skip to content

fix: support optional member detection with MSVC #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webern merged 1 commit into from
Jul 14, 2026
Merged

fix: support optional member detection with MSVC #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 36 additions & 27 deletions src/private/mx/utility/OptionalMembers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,38 +101,41 @@
\
template <class T> bool lookForAndSetHas##fieldNameCapitalized(bool has, T *const el) \
{ \
if constexpr (requires { el->setterName(std::nullopt); }) \
if constexpr (requires { el->fieldName(); }) \
{ \
if (!has) \
if constexpr (requires { el->setterName(std::nullopt); }) \
{ \
el->setterName(std::nullopt); \
if (!has) \
{ \
el->setterName(std::nullopt); \
} \
else if (!el->fieldName().has_value()) \
{ \
el->setterName(typename std::decay_t<decltype(el->fieldName())>::value_type{}); \
} \
return has; \
} \
else if (!el->fieldName().has_value()) \
{ \
el->setterName(typename std::decay_t<decltype(el->fieldName())>::value_type{}); \
} \
return has; \
} \
else \
{ \
return false; \
} \
return false; \
}

// Value setter for a clamped-decimal wrapper field.
#define MX_OPTIONAL_SET_DECIMAL_FUNC(fieldName, setterName, fieldNameCapitalized) \
\
template <class T, class VALUE_TYPE> void lookForAndSet##fieldNameCapitalized(VALUE_TYPE value, T *const el) \
{ \
if constexpr (requires { \
el->setterName(typename std::decay_t<decltype(el->fieldName())>::value_type{ \
mx::core::Decimal{static_cast<double>(value)}}); \
}) \
if constexpr (requires { el->fieldName(); }) \
{ \
if (el->fieldName().has_value()) \
if constexpr (requires { \
el->setterName(typename std::decay_t<decltype(el->fieldName())>::value_type{ \
mx::core::Decimal{static_cast<double>(value)}}); \
}) \
{ \
el->setterName(typename std::decay_t<decltype(el->fieldName())>::value_type{ \
mx::core::Decimal{static_cast<double>(value)}}); \
if (el->fieldName().has_value()) \
{ \
el->setterName(typename std::decay_t<decltype(el->fieldName())>::value_type{ \
mx::core::Decimal{static_cast<double>(value)}}); \
} \
} \
} \
}
Expand All @@ -142,13 +145,16 @@
\
template <class T> void lookForAndSet##fieldNameCapitalized(int value, T *const el) \
{ \
if constexpr (requires { \
el->setterName(typename std::decay_t<decltype(el->fieldName())>::value_type{value}); \
}) \
if constexpr (requires { el->fieldName(); }) \
{ \
if (el->fieldName().has_value()) \
if constexpr (requires { \
el->setterName(typename std::decay_t<decltype(el->fieldName())>::value_type{value}); \
}) \
{ \
el->setterName(typename std::decay_t<decltype(el->fieldName())>::value_type{value}); \
if (el->fieldName().has_value()) \
{ \
el->setterName(typename std::decay_t<decltype(el->fieldName())>::value_type{value}); \
} \
} \
} \
}
Expand All @@ -158,11 +164,14 @@
\
template <class T, class VALUE_TYPE> void lookForAndSet##fieldNameCapitalized(VALUE_TYPE value, T *const el) \
{ \
if constexpr (requires { el->setterName(std::move(value)); }) \
if constexpr (requires { el->fieldName(); }) \
{ \
if (el->fieldName().has_value()) \
if constexpr (requires { el->setterName(std::move(value)); }) \
{ \
el->setterName(std::move(value)); \
if (el->fieldName().has_value()) \
{ \
el->setterName(std::move(value)); \
} \
} \
} \
}
Loading