Skip to content

Vv/test automation - #264

Merged
vishnuv688 merged 77 commits into
mainfrom
vv/test-automation
Aug 3, 2026
Merged

Vv/test automation#264
vishnuv688 merged 77 commits into
mainfrom
vv/test-automation

Conversation

@vishnuv688

@vishnuv688 vishnuv688 commented Jul 27, 2026

Copy link
Copy Markdown
Member

What & why

Component tests for the Lit dashboard: 31 spec files, 892 tests, covering all 31
elements (was 13). Plus the ~30 bugs writing them found, and pnpm typecheck
a type gate that actually runs — wired into CI alongside the new suite.

To retire manual UI regression. The tests did that, but the more useful outcome
was what they exposed: six existing specs asserted broken behaviour as expected
and eight could not fail at all, so the gaps looked closed. And tsc had been
exiting on a deprecated option before checking anything, with nothing in CI
running it, which is how 28 type errors and a file that hadn't compiled since
June went unnoticed. Every assertion added here is mutation-checked: break what
it guards, confirm it fails.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Polish (an improvement to an existing feature)
  • Breaking change (existing behavior changes for users)
  • Documentation
  • Internal (build, CI, dependencies, tooling)

Packages touched

  • shared (types and contracts)
  • core (framework-agnostic capture/reporting)
  • service (WebdriverIO adapter)
  • nightwatch-devtools (Nightwatch adapter)
  • selenium-devtools (Selenium adapter)
  • backend (server)
  • app (UI)
  • script (page-injected runtime)

Notes for reviewers

Screenshots / recordings

Comment thread .github/workflows/verify.yml Fixed
@greptile-apps

greptile-apps Bot commented Jul 27, 2026

Copy link
Copy Markdown

Greptile Summary

Adds broad component and unit-test coverage for the Lit dashboard, fixes behaviors exposed by those tests, and introduces CI-enforced type checking and browser component tests.

  • Expands dashboard coverage across shell, sidebar, workbench, panel, player, and tab components.
  • Corrects UI state derivation, rendering, filtering, trace display, and controller behavior.
  • Updates shared, core, backend, adapter, and injected-script contracts and utilities.
  • Adds a working TypeScript gate and separate browser component-test CI job.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Adds type checking to the build job and runs browser component tests in a dedicated parallel job.
packages/app/src/controller/DataManager.ts Updates dashboard data orchestration and state propagation covered by the expanded test suite.
packages/app/src/components/workbench/network.ts Refines network-panel behavior and rendering with corresponding component and unit coverage.
packages/core/src/trace-exporter.ts Adjusts trace export behavior and associated trace-focused tests.
package.json Adds runnable typecheck and component-test commands used by CI.

Reviews (5): Last reviewed commit: "Merge pull request #266 from webdriverio..." | Re-trigger Greptile

Comment thread test/capture/capture-parity.test.ts Outdated
@vishnuv688

Copy link
Copy Markdown
Member Author

@greptile-apps

@vishnuv688

Copy link
Copy Markdown
Member Author

@greptile-apps

@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown

Too many files changed for review. (214 files found, 100 file limit)

Bypass the limit by tagging @greptile-apps to review.

@vishnuv688
vishnuv688 merged commit 0ff07b8 into main Aug 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants