Vv/test automation - #264
Merged
Merged
Conversation
Greptile SummaryAdds broad component and unit-test coverage for the Lit dashboard, fixes behaviors exposed by those tests, and introduces CI-enforced type checking and browser component tests.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| .github/workflows/ci.yml | Adds type checking to the build job and runs browser component tests in a dedicated parallel job. |
| packages/app/src/controller/DataManager.ts | Updates dashboard data orchestration and state propagation covered by the expanded test suite. |
| packages/app/src/components/workbench/network.ts | Refines network-panel behavior and rendering with corresponding component and unit coverage. |
| packages/core/src/trace-exporter.ts | Adjusts trace export behavior and associated trace-focused tests. |
| package.json | Adds runnable typecheck and component-test commands used by CI. |
Reviews (5): Last reviewed commit: "Merge pull request #266 from webdriverio..." | Re-trigger Greptile
Member
Author
fix: resolve the defects pinned during the UI-test pass
Member
Author
|
Too many files changed for review. ( Bypass the limit by tagging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Component tests for the Lit dashboard: 31 spec files, 892 tests, covering all 31
elements (was 13). Plus the ~30 bugs writing them found, and
pnpm typecheck—a type gate that actually runs — wired into CI alongside the new suite.
To retire manual UI regression. The tests did that, but the more useful outcome
was what they exposed: six existing specs asserted broken behaviour as expected
and eight could not fail at all, so the gaps looked closed. And
tschad beenexiting on a deprecated option before checking anything, with nothing in CI
running it, which is how 28 type errors and a file that hadn't compiled since
June went unnoticed. Every assertion added here is mutation-checked: break what
it guards, confirm it fails.
Type of change
Packages touched
shared(types and contracts)core(framework-agnostic capture/reporting)service(WebdriverIO adapter)nightwatch-devtools(Nightwatch adapter)selenium-devtools(Selenium adapter)backend(server)app(UI)script(page-injected runtime)Notes for reviewers
Screenshots / recordings