Fix biome colours for mangrove leaves#4269
Open
willymv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think I've seen this mentioned in any issues or on the Discord but it always bugged me how Mangrove leaves didn't have the right biome colour in Mangrove Swamps. Figured out how to fix it in my fork yesterday and this change looks like it follows the contribution guidelines so I thought I'd send it in.
NOTE Everything builds fine. I am not too confident with the texture_0/1.txt and model_0/1.txt files and their formatting but I don't believe this breaks anything as it just follows how other leaves (like oak) are added in this texture file. Apologies if I have missed something.
Here are some before and after pics. The right-hand side compares the mangrove leaves (bottom) to oak leaves (top) with a bunch of different biomes(forest, plains, desert, jungle and mangrove in that order).
Before
After
