feat: add experimental workspace sidebar persistence#993
Open
AnrokX wants to merge 11 commits into
Open
Conversation
The programmatic getDefaultSettings() and the tests already carry ui.experimental.workspaceTabState; the static user-settings.default.json template was missing it, leaving the two default sources out of sync. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
|
Reviewed as part of an open-PR sweep — this one holds up well despite its age: the feature is fully gated behind the off-by-default persistWorkspaceSidebarState flag, the merge simulation against current main is clean, the one ungated tweak (preserveVisibility guard) was verified backward-compatible and actually complements main's later double-broadcast startup fix, and the full unit suite passes on the simulated merged tree. Pushed one small fix: user-settings.default.json was missing workspaceTabState (the programmatic defaults and tests already had it). Verdict: good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan