fix(commander): close (✕) button should stop the session, not just hide (same as minimize)#1018
Open
SmolSmolStar wants to merge 2 commits into
Open
Conversation
The Commander titlebar's minimize (—) and close (✕) buttons both called hide(), so they did exactly the same thing (just hide the floating panel). Make them distinct and match window conventions: close (✕) now stops the Commander session (via stopCommander) and then hides, so it's a true close; minimize (—) keeps hiding only, leaving the session running for an instant re-open. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…iately Review feedback: the close (X) button silently killed a live Commander session on a single reflexive click, and the panel hung until the stop round-trip finished. Now a running session asks for confirmation first, the panel hides optimistically, and the stop call runs in the background (stopCommander already handles its own errors and never throws). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
|
Reviewed as part of an open-PR sweep. Pushed one fix on top: close (✕) now asks for confirmation when a session is actually running (it kills the live Commander process — too destructive for an unguarded titlebar click), and the panel hides immediately instead of hanging on the stop round-trip. Verdict after fix: good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Commander floating panel's minimize (—) and close (✕) buttons both call
hide(), so they do the exact same thing — just hide the panel. That makes one of them redundant and there's no way to actually close the Commander session from the titlebar.Fix
Make them distinct, matching normal window conventions:
closeSession(): stops the Commander session (stopCommander()→POST /api/commander/stop), then hides the panel. Reopening starts a fresh Commander.hide(): only hides the window, leaves the session running for an instant re-open.Test plan
🤖 Generated with Claude Code