Re-implementation #117
Draft
RobSlgm wants to merge 10 commits intoweb-push-libs:masterfrom
Draft
Conversation
add new interfaces
- Mark calls with dictionary parameter as obsolete
Member
|
This looks amazing, thank you. I'll take a proper look over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion in #115 this PR contains the proposed changes (see there for a suggest way to proceed).
This PR would close following issues:
I am using a separate fork for this PR to avoid introducing breaking changes from my production environment in https://github.com/closureOSS/webpush-csharp. Specifically, this excludes my updates for nullable support, API removals, and custom NuGet publishing workflows.