Skip to content

script: Claim blob before loading <video> poster frame#59049

Open
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_44035
Open

script: Claim blob before loading <video> poster frame#59049
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_44035

Conversation

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

Refer to servo/servo#43746 for a description of the problem. This change ensures that video posters can be loaded from blob URLs, even if the URL is revoked right after.

Testing: This change adds a test
Reviewed in servo/servo#44035

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Copy link
Copy Markdown
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Servo project.

@servo-wpt-sync servo-wpt-sync added stale-servo-export PRs that were supposed to merge but were not able to do so. and removed do not merge yet labels Apr 8, 2026
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator Author

⛔ The downstream PR has merged (servo/servo#44035), but these changes could not be merged properly. Please address any CI issues and try to merge manually.

@jdm
Copy link
Copy Markdown
Contributor

jdm commented Apr 8, 2026

@simonwuelker Looks like the test might have intermittent results in other browsers, which could be due to implementation bugs like the one we fixed in Servo. I will ask in matrix how to proceed.

@simonwuelker
Copy link
Copy Markdown
Contributor

simonwuelker commented Apr 8, 2026

Maybe the test removes test-wait too early. I'll check later.

The problem is probably using oncanplaythrough. The existing video-poster-shown-auto-preload.html test (which I based my test on) waits for that event to delay comparison for reftests, but I think that only works because the poster fetch itself already delays the load event.

I'm unsure how to make sure that the screenshot is taken after the poster is loaded... Since in our case the load event fires long before the blob URL is created, so its not delayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

html servo-export stale-servo-export PRs that were supposed to merge but were not able to do so.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants