Skip to content

Codify the requestAnimationFrame delay in test-wait.js as the test-completion timing#241

Open
gsnedders wants to merge 1 commit into
web-platform-tests:mainfrom
gsnedders:test-wait-double-rAF
Open

Codify the requestAnimationFrame delay in test-wait.js as the test-completion timing#241
gsnedders wants to merge 1 commit into
web-platform-tests:mainfrom
gsnedders:test-wait-double-rAF

Conversation

@gsnedders

Copy link
Copy Markdown
Member

@jcscottiii

Copy link
Copy Markdown
Contributor

I talked to Xianzhu about this. They said:

I agree with https://issues.chromium.org/issues/41311503#comment3 that the WebDriver should be able to reliably capture an image reflecting the document's latest status, without the client needing to do anything.

I don't remember many details, but crrev.com/c/4505400 now looks like a temporary solution to make the two web test runners do the same thing. It was probably a workaround for the issue where some ref tests had [double-]rAF etc., which required waiting, but the tests didn't declare reftest-wait, causing flaky premature finishes (e.g. crbug.com/40899923, crbug.com/ crrev.com/c/40901018). Now I think we should find and fix the tests instead of working around them in the test runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants