safe-printable-inset META value proposal#233
safe-printable-inset META value proposal#233mstensho wants to merge 5 commits intoweb-platform-tests:mainfrom
Conversation
jcscottiii
left a comment
There was a problem hiding this comment.
LGTM. I only have one question.
rfcs/safe-printable-inset.md
Outdated
|
|
||
| where `inset-specifier` is a numeric value. The unit could be CSS pixels or | ||
| points. Using centimeters for anything here isn't a great idea, since they don't | ||
| convert nicely into CSS pixels (unlike inches). I suggest using CSS pixels. |
There was a problem hiding this comment.
Question: Is it worth it to enforce the usage of pixels here? (Or rather what's the risk if we don't enforce it?)
When new metadata is introduced, there's a risk of incorrect usage (e.g., typos, invalid values, or inappropriate units). For example, a value like content="2in" might be provided, even though the RFC suggests CSS pixels or points and discourages inches. The best way to mitigate this is to add automated checks. Other places that handled something similar:
- RFC 163 (web_features) added a lint to ensure its new metadata didn't get out of sync with test files
- RFC 158 (Variant name should be a non-zero length string) added a lint to forbid a problematic authoring pattern
- RFC 211 (Support testdriver.js in other test types) proposed a lint to enforce correct usage with
reftest-wait.
There was a problem hiding this comment.
I was thinking a unitless value, which is why I'm suggesting pixels. But I suppose we could require units (and even allow centimeters, for all those rounding error fans out there) to be specified as part of the value instead?
gsnedders
left a comment
There was a problem hiding this comment.
Mostly my question is "how would we hook this up to the style engine", because somehow we have to go from the meta element to this impacting print style and output.
Most of the time we're using WebDriver to communicate with the browser; does it therefore make sense to add something to the WebDriver print command that specifies the safe printable inset? My gut is yes?
|
Here's something I hacked together for testing. https://chromium-review.googlesource.com/c/chromium/src/+/7415241 Does this answer your question? |
|
@gsnedders Are you asking whether we should add something to https://w3c.github.io/webdriver/#print-page ? I think that might be a good idea. It could be specified as a single inset value, or it could be a rectangle within Is everything in centimeters here? That's rather bad, since they don't convert nicely to CSS pixels. But I suppose we need to follow suit. |
gsnedders
left a comment
There was a problem hiding this comment.
@gsnedders Are you asking whether we should add something to https://w3c.github.io/webdriver/#print-page ?
Yes, which appears to be what the draft CL does. Can you please make a PR against WebDriver, and get consensus there first?
I think that might be a good idea. It could be specified as a single inset value, or it could be a rectangle within
pageWidthxpageHeight.
It should allow both separately, I'd expect.
Is everything in centimeters here? That's rather bad, since they don't convert nicely to CSS pixels. But I suppose we need to follow suit.
Yes, which is… deeply unfortunate, I agree. Though to be fair, A4 paper doesn't convert nicely to CSS pixels either. :)
What's the name of the repo?
I really think one of them should be enough. But that can be discussed there.
Hey, A4 doesn't even convert nicely to centimeters. The height being 21cm * sqrt(2). :-p |
For print reftests, check <meta name="safe-printable-inset"> to simulate an unprintable region along the paper edges. The `content` attribute takes a non-negative number, which is the safe printable inset specified in centimeters. Only implemented for executorwebdriver. Spec discussion: w3c/csswg-drafts#11395 Spec change: w3c/csswg-drafts#13190 RFC: web-platform-tests/rfcs#233 For background, see https://drafts.csswg.org/css-page-3/#printable-area
|
wptrunner and webdriver code changes PR here: web-platform-tests/wpt#58030 |
This is for testing the `page-margin-safety` descriptor in `@page` and page margin box contexts. Spec discussion: w3c/csswg-drafts#11395 Spec change: w3c/csswg-drafts#13190 RFC: web-platform-tests/rfcs#233 wptrunner and webdriver code changes: web-platform-tests/wpt#58030
|
webdriver spec change: w3c/webdriver#1950 |
|
The css-page spec changes have landed, and I've updated the description here accordingly. |
|
Updated the RFC to use centimeters. Please have another look. Thank you. |
|
I went with a single value for all four edges for now. As pointed out in the spec, the browser usually cannot make assumptions about which edge ends up where. |
|
We talked about this today. @gsnedders is commenting on w3c/webdriver#1950 and w3c/csswg-drafts#11395 |
| Why just one value for all four edges? Although many printers indeed don't | ||
| necessarily have a uniform unprintable area width along each of the four paper | ||
| edges (although many do), so that just providing one value for all is an | ||
| oversimplification of reality, printers may rotate the print output at their own | ||
| discretion. The user agent may therefore not be able to make assumptions about | ||
| which edge (long or short?) will be fed first into the printer, or what | ||
| orientation the sheet of paper has. Therefore using just one value (which should | ||
| represent the larger of the four) seems reasonable. |
There was a problem hiding this comment.
This does leave us unable to test all the different at-rules the descriptor applies to — @page, @top-left-corner, @top-left, @top-center, @top-right, @top-right-corner, @right-top, @right-middle, @right-bottom, @bottom-right-corner, @bottom-right, @bottom-center, @bottom-left, @bottom-left-corner, @left-bottom, @left-middle, @left-top.
The spec says, along these lines:
Some printers don’t have a uniform unprintable area width along each of the four paper edges, and the printer may rotate the print output at their own discretion. The user agent may therefore not be able to make assumptions about which edge will be fed first into the printer, or what orientation the sheet of paper has. If the user agent cannot make such assumptions, only one will be provided (to be used on all 4 sides): The larger of these four values. Otherwise, if the user agent can trust that the four values are usable individually, and that no rotation is going to take place, and so on, each side of the page may have individual values.
It's not entirely clear to me from the spec how you go from potentially seventeen values (if specified in @page and all the margin at-rules) to only one, because the "larger of these four values" makes an assumption that you've already gone from seventeen to four.
Maybe starting with taking a single value is fine — but I could easily see us wanting to extend the metadata to take four values (potentially with semantics similar to the margin property?) to be able to actually test the case where the user agent can make assumptions about what edge will be fed first.
There was a problem hiding this comment.
We're not unable to test any of those at-rules. The safe printable inset will just be the same along each of the four edges.
@page is adjacent to all four edges of a paper sheet, so all of margin-top, margin-right, margin-bottom and margin-left may be affected by page margin safety. @blah-corner is adjacent to two of the edges. The remaining at-rules are adjacent to only one edge. For e.g. @top-center, only margin-top may be affected by page margin safety. For @bottom-right-corner, margin-right and margin-bottom may be affected.
Here's a test (not yet landed): https://chromium-review.googlesource.com/c/chromium/src/+/7415846/4/third_party/blink/web_tests/external/wpt/css/css-page/safe-printable-inset-003-print.html
Spec: https://drafts.csswg.org/css-page-3/#page-margin-safety
Spec discussion: w3c/csswg-drafts#11395