feat(query): add Boost parameter to all query types#592
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
…oes not know how to read
…client does not know how to read" This reverts commit eafa90a.
Namespaces permissions are not supported by the client yet. The tests will fail because admin role has those permissions. The client is supposed to fail when it encounters unknown permissions.
Member
|
LGTM, just one comment the python client checks that depth is not set on sub boosts. Would be good to also validate this in the java client (couldn't find if this exists). if len(boosts) == 0:
raise WeaviateInvalidInputError("Boost.blend() requires at least one boost.")
for r in boosts:
if r.depth is not None:
raise WeaviateInvalidInputError(
"Cannot set `depth` on sub-boosts passed to `blend()`. Use the top-level `depth` parameter instead."
) |
Collaborator
Author
|
@trengrj added that validation 👍 As a general rule, I try to let the server validate the request and not duplicate that logic on the client as well; this is a good example of a situation in which the server wouldn't even known |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Boost parameter to all query types. The API mirrors the reference implementation in the Python client.
N.B.: a big chunk of the diff is the re-generated WeaviateProtoSearchGet (~6.2K), which can be safely ignored.
Closes #576