Skip to content

Add effective dates to ToU and HP pages and fix versions panel - #1167

Merged
dati18 merged 10 commits into
mainfrom
eff-date-version-panel-fix
Aug 13, 2026
Merged

Add effective dates to ToU and HP pages and fix versions panel#1167
dati18 merged 10 commits into
mainfrom
eff-date-version-panel-fix

Conversation

@dati18

@dati18 dati18 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
  • Add Effective date in the subheader of the HP and ToU pages
  • In the policy navigation panel, the ToU versions' titles are formatted to <DD Month YYYY> (current) (e.g., 1 January 2022 (current) or 1 January 2021, not Current version or 2021-01-01)

Bug: T434191

@github-actions

Copy link
Copy Markdown

Deployment previews on netlify for branch refs/pull/1167/merge will be at the following locations (when build is done):

@dati18
dati18 force-pushed the eff-date-version-panel-fix branch from c0f69e2 to d0d8aac Compare August 10, 2026 16:07
outdooracorn
outdooracorn previously approved these changes Aug 13, 2026

@outdooracorn outdooracorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long for me to review. I had to remind myself how JavaScript/Vue works and all the Policy code is gnarly. 😅

  • From my local testing, and review of the code, these changes look correct.
  • I've left some minor suggestions for improvements to the title (heading and subheading).
  • There are still some things that don't align with the design and the task's A/C includes UI matches design specs:
    • "previous version" in "What changed from the previous version" is the only part that should be linked (i.e. move "the" to outside the router-link tag).
    • "previous version" should also be underlined. I'm not sure why the router-link tag has a text-decoration-none Vuetify2 CSS class, but the designs suggest that this should be removed.
    • The of in "Terms of Use" title should be lower-case.
    • There are also some other things that I noticed, but I don't think they really belong to T434191, so I'll write them elsewhere. For future learning, "UI matches design specs" is probably too vague an A/C for this type of specific task (I've updated the task to be more specific, so the scope of this task doesn't creep).

You could make these changes in this PR or in one or more follow-up PRs. I've approved this PR to enable that flexibility as it correctly does what it says.

Comment thread src/components/Pages/HostingPolicy/hosting-policy/version-1.vue Outdated
Comment thread src/components/Pages/TermsOfUse/terms-of-use/version-2.vue Outdated
Comment thread src/components/Pages/TermsOfUse/terms-of-use/version-1.vue Outdated
@outdooracorn outdooracorn changed the title Add effective dates to ToU and HP pages and a fix to versions panel Add effective dates to ToU and HP pages and fix versions panel Aug 13, 2026

@outdooracorn outdooracorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gahh! I always think suggestions will be helpful, and then they never quite apply as you think they will :/

Comment thread src/components/Pages/TermsOfUse/terms-of-use/version-1.vue Outdated

@outdooracorn outdooracorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get this merged and unblock other work. The other issues noted in my comment can be addressed in a follow-up.

@dati18
dati18 merged commit 60bb198 into main Aug 13, 2026
7 checks passed
@dati18
dati18 deleted the eff-date-version-panel-fix branch August 13, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants