Add effective dates to ToU and HP pages and fix versions panel - #1167
Conversation
|
Deployment previews on netlify for branch
|
c0f69e2 to
d0d8aac
Compare
There was a problem hiding this comment.
Sorry this took so long for me to review. I had to remind myself how JavaScript/Vue works and all the Policy code is gnarly. 😅
- From my local testing, and review of the code, these changes look correct.
- I've left some minor suggestions for improvements to the title (heading and subheading).
- There are still some things that don't align with the design and the task's A/C includes
UI matches design specs:- "previous version" in "What changed from the previous version" is the only part that should be linked (i.e. move "the" to outside the
router-linktag). - "previous version" should also be underlined. I'm not sure why the
router-linktag has atext-decoration-noneVuetify2 CSS class, but the designs suggest that this should be removed. - The
ofin "Terms of Use" title should be lower-case. - There are also some other things that I noticed, but I don't think they really belong to T434191, so I'll write them elsewhere. For future learning, "UI matches design specs" is probably too vague an A/C for this type of specific task (I've updated the task to be more specific, so the scope of this task doesn't creep).
- "previous version" in "What changed from the previous version" is the only part that should be linked (i.e. move "the" to outside the
You could make these changes in this PR or in one or more follow-up PRs. I've approved this PR to enable that flexibility as it correctly does what it says.
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
3b4a41a to
897e6e9
Compare
outdooracorn
left a comment
There was a problem hiding this comment.
Gahh! I always think suggestions will be helpful, and then they never quite apply as you think they will :/
outdooracorn
left a comment
There was a problem hiding this comment.
Approving to get this merged and unblock other work. The other issues noted in my comment can be addressed in a follow-up.
Effectivedate in the subheader of the HP and ToU pages<DD Month YYYY> (current)(e.g.,1 January 2022 (current)or1 January 2021, notCurrent versionor2021-01-01)Bug: T434191