Skip to content

Fix MSVC C4996/C4242 warnings in C API #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wavefunction91 merged 2 commits into from
Jun 25, 2026
Merged

Fix MSVC C4996/C4242 warnings in C API #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bae9a4
Fix MSVC C4996/C4242 warnings in C API
lorisercole Jun 16, 2026
1e9d122
Guard split() with EXCHCXX_ENABLE_LIBXC to fix unused-function warning
lorisercole Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/c-api/c_functional.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include "c_functional.hpp"
#include "c_status.hpp"

#ifdef EXCHCXX_ENABLE_LIBXC
namespace GauXC::detail {
/**
* Splits a string into tokens based on a delimiter
Expand All @@ -28,7 +29,7 @@ namespace GauXC::detail {
* \param [in] str std::string to split
* \param [in] delimiters Delimiters on which to split str
*/
static inline void split(std::vector<std::string>& tokens,
static inline void split(std::vector<std::string>& tokens,
const std::string& str, const std::string& delimiters = " ") {

tokens.clear();
Expand All @@ -47,6 +48,7 @@ static inline void split(std::vector<std::string>& tokens,
}
}; // split
} // namespace GauXC::detail
#endif

namespace GauXC::C {
extern "C" {
Expand Down
5 changes: 3 additions & 2 deletions src/c-api/c_status.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ static inline void gauxc_status_handle(C::GauXCStatus* status, int code, const c
if (status->message != nullptr) {
std::free(status->message);
}
status->message = (char*)std::malloc(std::strlen(message) + 1);
std::strcpy(status->message, message);
const std::size_t len = std::strlen(message) + 1;
status->message = (char*)std::malloc(len);
std::memcpy(status->message, message, len);
} else {
GAUXC_GENERIC_EXCEPTION(message);
}
Expand Down
3 changes: 2 additions & 1 deletion src/c-api/c_xc_integrator.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ GauXCIntegrator gauxc_integrator_new(

// Create Integrator instance
auto input_type_ = std::string(integrator_input_type);
std::transform( input_type_.begin(), input_type_.end(), input_type_.begin(), ::toupper );
std::transform( input_type_.begin(), input_type_.end(), input_type_.begin(),
[](unsigned char c) { return static_cast<char>(std::toupper(c)); } );

if( input_type_ != "REPLICATED" ) GAUXC_GENERIC_EXCEPTION("INTEGRATOR TYPE NOT RECOGNIZED");

Expand Down
Loading