Avoid panic in file drop target QueryInterface - #27
Merged
acarl005 merged 1 commit intoSep 23, 2026
Merged
Conversation
Author
|
This PR was generated with Warp. Comment |
warp-agent-staging
Bot
force-pushed
the
factory/implement-drop-handler-query-interface
branch
from
September 23, 2026 20:44
665cdab to
86e93bd
Compare
acarl005
marked this pull request as ready for review
September 23, 2026 21:26
acarl005
approved these changes
Sep 23, 2026
warp-agent-staging
Bot
force-pushed
the
factory/implement-drop-handler-query-interface
branch
from
September 23, 2026 21:39
1ca562d to
65ef7b9
Compare
warp-agent-staging
Bot
changed the base branch from
v0.30.x
to
warpdotdev/v0.30.x
September 23, 2026 21:39
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Avoids panicking across the COM/FFI boundary when Windows calls the file drop target's
QueryInterface. Sentry fatal WARP-CLIENT-BETA-STABLE-8C07 occurred when an injected Island DLP hook reached the existingunimplemented!().This change matches upstream rust-windowing/winit#4571: it logs a warning and returns
E_FAIL. It is based on Warp's maintainedwarpdotdev/v0.30.xbranch and leaves file drag behavior unchanged outside interface queries that previously aborted the process.Validation
cargo check --target x86_64-pc-windows-gnu --libRUSTFLAGS='--codegen=debuginfo=0 --deny=warnings' cargo build --target x86_64-pc-windows-gnugit diff --checkcargo clippy --target x86_64-pc-windows-gnu --lib -- -D warningsis blocked by three existingclippy::incompatible_msrverrors in unchangedsrc/platform_impl/windows/util.rs.cargo +nightly fmtcompleted; unrelated formatting in unchangedevent_loop.rswas reverted.Tested on all platforms changed — Windows GNU cross-target checks passed; native Windows/MSVC runtime validation remains for CI or reviewer testing.
Added an entry to the
changelogmodule if knowledge of this change could be valuable to users — no API or workflow change.Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior — no public API or documented behavior changed.
Created or updated an example program if it would help users understand this functionality — not applicable to this FFI failure-path fix.
Addresses fatal issue 7750551209 and event
6a1874f230e841c8ba0cd1ca9ec3957e.