Skip to content

Avoid panic in file drop target QueryInterface - #27

Merged
acarl005 merged 1 commit into
warpdotdev/v0.30.xfrom
factory/implement-drop-handler-query-interface
Sep 23, 2026
Merged

acarl005 merged 1 commit into
warpdotdev/v0.30.xfrom
factory/implement-drop-handler-query-interface

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Avoids panicking across the COM/FFI boundary when Windows calls the file drop target's QueryInterface. Sentry fatal WARP-CLIENT-BETA-STABLE-8C07 occurred when an injected Island DLP hook reached the existing unimplemented!().

This change matches upstream rust-windowing/winit#4571: it logs a warning and returns E_FAIL. It is based on Warp's maintained warpdotdev/v0.30.x branch and leaves file drag behavior unchanged outside interface queries that previously aborted the process.

Validation

  • cargo check --target x86_64-pc-windows-gnu --lib

  • RUSTFLAGS='--codegen=debuginfo=0 --deny=warnings' cargo build --target x86_64-pc-windows-gnu

  • git diff --check

  • cargo clippy --target x86_64-pc-windows-gnu --lib -- -D warnings is blocked by three existing clippy::incompatible_msrv errors in unchanged src/platform_impl/windows/util.rs.

  • cargo +nightly fmt completed; unrelated formatting in unchanged event_loop.rs was reverted.

  • Tested on all platforms changed — Windows GNU cross-target checks passed; native Windows/MSVC runtime validation remains for CI or reviewer testing.

  • Added an entry to the changelog module if knowledge of this change could be valuable to users — no API or workflow change.

  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior — no public API or documented behavior changed.

  • Created or updated an example program if it would help users understand this functionality — not applicable to this FFI failure-path fix.

Addresses fatal issue 7750551209 and event 6a1874f230e841c8ba0cd1ca9ec3957e.

@warp-agent-staging

Copy link
Copy Markdown
Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation

@warp-agent-staging
warp-agent-staging Bot force-pushed the factory/implement-drop-handler-query-interface branch from 665cdab to 86e93bd Compare September 23, 2026 20:44
@warp-agent-staging warp-agent-staging Bot changed the title Implement file drop target QueryInterface Avoid panic in file drop target QueryInterface Sep 23, 2026
@warp-agent-staging
warp-agent-staging Bot changed the base branch from master to v0.30.x September 23, 2026 20:44
@acarl005
acarl005 marked this pull request as ready for review September 23, 2026 21:26
@warp-agent-staging
warp-agent-staging Bot force-pushed the factory/implement-drop-handler-query-interface branch from 1ca562d to 65ef7b9 Compare September 23, 2026 21:39
@warp-agent-staging
warp-agent-staging Bot changed the base branch from v0.30.x to warpdotdev/v0.30.x September 23, 2026 21:39
@acarl005
acarl005 merged commit cb0ba31 into warpdotdev/v0.30.x Sep 23, 2026
7 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants