Clean up ExpandEditToPane feature flag - #14626
Conversation
|
@oz-for-oss[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR removes the ExpandEditToPane Cargo feature and FeatureFlag variant, making the code-diff pane replacement path unconditional.
Concerns
- The PR changes user-visible code-diff behavior but the description does not include screenshots or a screen recording demonstrating the flow end to end.
- The pane replacement failure log still says it is falling back to a new tab even though the fallback branch was removed.
Verdict
Found: 0 critical, 1 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| let (new_idx, group_id) = self.new_tab_index_and_group(ctx); | ||
| self.add_tab_from_existing_pane(Box::new(new_pane), new_idx, group_id, ctx); | ||
| } | ||
| // Try to temporarily replace the current pane with the diff view |
There was a problem hiding this comment.
| if !pane_group.replace_pane(focused_pane_id, new_pane, true, ctx) { | ||
| // If replacement failed, remove the pane we just added and fall back | ||
| //pane_group.close_pane(new_pane_id, ctx); | ||
| log::warn!("Failed to temporarily replace pane, falling back to new tab"); |
There was a problem hiding this comment.
💡 [SUGGESTION] This message no longer matches the behavior because the new-tab fallback was removed.
| log::warn!("Failed to temporarily replace pane, falling back to new tab"); | |
| log::warn!("Failed to temporarily replace pane with code diff view"); |
1 participant
Automated cleanup of the
ExpandEditToPanefeature flag.This PR was generated by the feature flag cleanup workflow.